Skip to content

Conversation

@scottgerring
Copy link
Member

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

exporter.shutdown();
exporter
.shutdown()
.map_err(|e| LogError::Other(Box::new(e)))?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be ShutdownError::InternalFailure?
Same with the else branch here dealing with mutexpoison.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cijothomas to be clear you're suggesting that we change trait LogProcessor's shutdown signature as well, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@codecov
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 46.42857% with 15 lines in your changes missing coverage. Please review.

Project coverage is 79.5%. Comparing base (dde68a0) to head (106e4b4).

Files with missing lines Patch % Lines
opentelemetry-otlp/src/exporter/http/logs.rs 0.0% 6 Missing ⚠️
opentelemetry-sdk/src/logs/export.rs 0.0% 3 Missing ⚠️
opentelemetry-otlp/src/exporter/tonic/logs.rs 0.0% 2 Missing ⚠️
...y-sdk/src/logs/log_processor_with_async_runtime.rs 71.4% 2 Missing ⚠️
opentelemetry-stdout/src/logs/exporter.rs 0.0% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2588     +/-   ##
=======================================
- Coverage   79.5%   79.5%   -0.1%     
=======================================
  Files        118     118             
  Lines      22480   22498     +18     
=======================================
+ Hits       17878   17886      +8     
- Misses      4602    4612     +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scottgerring scottgerring force-pushed the chore/add-errors-to-export branch 2 times, most recently from 1ef8a02 to b8ee60c Compare February 5, 2025 13:51
@scottgerring scottgerring force-pushed the chore/add-errors-to-export branch from b8ee60c to 466c1ec Compare February 5, 2025 14:22
@scottgerring scottgerring deleted the chore/add-errors-to-export branch February 10, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants