Skip to content

Conversation

@lalitb
Copy link
Member

@lalitb lalitb commented Feb 4, 2025

Fixes #
To validate #2583 for logs:

  • Reduce the sleep to 2 secs, to ensure that the sleep due the logs export is done during shutdown, and timer expiry.
  • Invoke shutdown in separate thread for tokio current_thread mode.

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner February 4, 2025 00:52
@lalitb lalitb added the integration tests Run integration tests label Feb 4, 2025
@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.2%. Comparing base (b017c7b) to head (4d17751).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2601   +/-   ##
=====================================
  Coverage   79.2%   79.2%           
=====================================
  Files        118     118           
  Lines      22503   22503           
=====================================
  Hits       17829   17829           
  Misses      4674    4674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


let _ = logger_provider.shutdown();
std::thread::sleep(Duration::from_secs(5));
std::thread::sleep(Duration::from_secs(2));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets keep 5 for now throughout.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once #2588 lands, we need to assert that shutdown returns expected Ok variant.

@lalitb lalitb merged commit f5b44a5 into open-telemetry:main Feb 4, 2025
21 checks passed
bantonsson pushed a commit to bantonsson/opentelemetry-rust that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration tests Run integration tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants