Changelog refactoring #2632
Merged
Changelog refactoring #2632
+247
−429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2632 +/- ##
=====================================
Coverage 79.1% 79.1%
=====================================
Files 119 119
Lines 22556 22556
=====================================
Hits 17857 17857
Misses 4699 4699 ☔ View full report in Codecov by Sentry. |
lalitb
reviewed
Feb 7, 2025
| - `opentelemetry::global::shutdown_tracer_provider()` removed from the API, should now use `tracer_provider.shutdown()` see [#2369](https://github.com/open-telemetry/opentelemetry-rust/pull/2369) for a migration example. "Tracer provider" is cheaply clonable, so users are encouraged to set a clone of it as the global (ex: `global::set_tracer_provider(provider.clone()))`, so that instrumentations and other components can obtain tracers from `global::tracer()`. The tracer_provider must be kept around to call shutdown on it at the end of application (ex: `tracer_provider.shutdown()`) | ||
| Note: Due to the large amount of making changes, check [migration guide to | ||
| 0.28](../docs/migration_0.28.md) for a summary that can help majority users to | ||
| quickly migrate. The changelog below is the full list of changes. |
Member
There was a problem hiding this comment.
Does it make sense to group these changes based on the signals, and exporters this time, would be easy to users to see the relevant part which affects them?
Member
Author
There was a problem hiding this comment.
most changes affect multiple signals... But still I can do another reordering to get signals specific one close to each other
lalitb
approved these changes
Feb 7, 2025
bantonsson
pushed a commit
to bantonsson/opentelemetry-rust
that referenced
this pull request
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly for SDK, rearranged changelings, grouping relevant ones together.