Skip to content

Conversation

@drewrelmas
Copy link
Contributor

Fixes # (Not Applicable)
Design discussion issue (if applicable) # (Not Applicable)

Changes

After cloning down the repository for the first time on Windows, noticed build failures in 2 places around import of pprof crate:

failed to resolve: use of undeclared crate or module pprof
use of undeclared crate or module pprof

Looking at other references in the project, including the cargo.toml, it is clear they should have [cfg markers disabling them for Windows developers.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@drewrelmas drewrelmas requested a review from a team as a code owner February 11, 2025 18:24
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.0%. Comparing base (189078d) to head (1e47616).
Report is 3 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2648   +/-   ##
=====================================
  Coverage   79.0%   79.0%           
=====================================
  Files        120     120           
  Lines      22512   22512           
=====================================
  Hits       17791   17791           
  Misses      4721    4721           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 2d7e7d6 into open-telemetry:main Feb 11, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants