Skip to content

Conversation

@BSteffaniak
Copy link
Contributor

Changes

Upgrade the dependencies to the latest 0.28 version and fix breaking changes.

I noticed this issue regarding discontinuing the prometheus crate: #2451

If that is the plan, you may want to disregard this PR. Although, I am not sure what the proper way to transition from using the opentelemetry-prometheus crate to just simply using otlp natively would involve. Any pointers there would be much appreciated.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@BSteffaniak BSteffaniak requested a review from a team as a code owner February 11, 2025 18:57
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 11, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.0%. Comparing base (f3a375c) to head (02efe8e).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2650   +/-   ##
=====================================
  Coverage   79.0%   79.0%           
=====================================
  Files        120     120           
  Lines      22512   22512           
=====================================
  Hits       17791   17791           
  Misses      4721    4721           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas
Copy link
Member

Although, I am not sure what the proper way to transition from using the opentelemetry-prometheus crate to just simply using otlp natively would involve. Any pointers there would be much appreciated.

I'll make a doc on this shortly! (I have been busy with release, else would have published this earlier.)

Irrespective, discontinuing this complete needs more discussion among all maintainers (and probably spec too), so this PR can be still considered.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good to have changelog for bumping the otel versions.

@BSteffaniak
Copy link
Contributor Author

BSteffaniak commented Feb 11, 2025

@lalitb:

Should I make additions to the root CHANGELOG.md as well as the opentelementry-prometheus/CHANGELOG.md?

(nevermind, noticed that there isnt a 'root' CHANGELOG.md)

@lalitb lalitb merged commit b358202 into open-telemetry:main Feb 11, 2025
21 checks passed
@lalitb
Copy link
Member

lalitb commented Feb 11, 2025

The package is published now - https://crates.io/crates/opentelemetry-prometheus/0.28.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants