-
Notifications
You must be signed in to change notification settings - Fork 600
Upgrade opentelemetry-prometheus to 0.28 #2650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4b8b01c to
02efe8e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2650 +/- ##
=====================================
Coverage 79.0% 79.0%
=====================================
Files 120 120
Lines 22512 22512
=====================================
Hits 17791 17791
Misses 4721 4721 ☔ View full report in Codecov by Sentry. |
I'll make a doc on this shortly! (I have been busy with release, else would have published this earlier.) Irrespective, discontinuing this complete needs more discussion among all maintainers (and probably spec too), so this PR can be still considered. |
lalitb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good to have changelog for bumping the otel versions.
|
Should I make additions to the root CHANGELOG.md as well as the opentelementry-prometheus/CHANGELOG.md? (nevermind, noticed that there isnt a 'root' CHANGELOG.md) |
a14bd28 to
c8b39bd
Compare
|
The package is published now - https://crates.io/crates/opentelemetry-prometheus/0.28.0 |
Changes
Upgrade the dependencies to the latest 0.28 version and fix breaking changes.
I noticed this issue regarding discontinuing the prometheus crate: #2451
If that is the plan, you may want to disregard this PR. Although, I am not sure what the proper way to transition from using the opentelemetry-prometheus crate to just simply using otlp natively would involve. Any pointers there would be much appreciated.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes