Skip to content

Conversation

@cijothomas
Copy link
Member

Resource needs to be handed over to each provider, so it must be created or cloned anyway.

@cijothomas cijothomas requested a review from a team as a code owner February 13, 2025 16:45
@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.1%. Comparing base (e68fe94) to head (e88d7d0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2660   +/-   ##
=====================================
  Coverage   79.1%   79.1%           
=====================================
  Files        120     120           
  Lines      22556   22556           
=====================================
  Hits       17857   17857           
  Misses      4699    4699           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas
Copy link
Member Author

On second thought, this is not good, as it need to detect resources again and again. Better to use OnceLock and clone.
Let me change

@cijothomas cijothomas requested a review from lalitb February 13, 2025 17:40
@cijothomas cijothomas merged commit 1aca212 into open-telemetry:main Feb 13, 2025
21 checks passed
@cijothomas cijothomas deleted the cijothomas/otlp-example-resource branch February 13, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants