Skip to content

Conversation

@cijothomas
Copy link
Member

Fixes #1682

No change in performance.
Also modified benchmarks to remove the need of a noop exporter, as noop processor is sufficient to test perf for enabled/disabled. (This change has no perf impact even without this cleanup.)

@cijothomas cijothomas requested a review from a team as a code owner February 14, 2025 18:11
@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.1%. Comparing base (41b381a) to head (63e1b95).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-appender-tracing/src/layer.rs 88.8% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2668     +/-   ##
=======================================
- Coverage   79.1%   79.1%   -0.1%     
=======================================
  Files        122     122             
  Lines      22562   22560      -2     
=======================================
- Hits       17861   17858      -3     
- Misses      4701    4702      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@cijothomas cijothomas merged commit dbd44a3 into open-telemetry:main Feb 14, 2025
20 of 21 checks passed
@cijothomas cijothomas deleted the cijothomas/fix1682 branch February 14, 2025 23:26
cijothomas added a commit to cijothomas/opentelemetry-rust that referenced this pull request Feb 18, 2025
bantonsson pushed a commit to bantonsson/opentelemetry-rust that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

otel-appender-tracing can suppress other tracing layers

2 participants