Skip to content

Conversation

@gruebel
Copy link
Member

@gruebel gruebel commented Feb 16, 2025

Changes

  • Rust added in 1.74 (I think 😅) the possibility to configure the lints for a whole workspace in the Cargo.toml. Since prometheus doesn't belong to the workspace it is handled separately. Now you can easily configure lints for all workspace crates 🍻

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@gruebel gruebel requested a review from a team as a code owner February 16, 2025 09:12
@codecov
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.1%. Comparing base (eca1ce8) to head (34463e1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2674   +/-   ##
=====================================
  Coverage   79.1%   79.1%           
=====================================
  Files        122     122           
  Lines      22546   22546           
=====================================
  Hits       17853   17853           
  Misses      4693    4693           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 1b1ba89 into open-telemetry:main Feb 18, 2025
21 checks passed
@gruebel gruebel deleted the use-workspace-lint branch February 18, 2025 19:12
bantonsson pushed a commit to bantonsson/opentelemetry-rust that referenced this pull request Oct 9, 2025
bantonsson pushed a commit to bantonsson/opentelemetry-rust that referenced this pull request Oct 9, 2025
bantonsson pushed a commit to bantonsson/opentelemetry-rust that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants