From cbe5834ab16a03c67a2d06883b3b2e18cf44b012 Mon Sep 17 00:00:00 2001 From: Cijo Thomas Date: Tue, 18 Mar 2025 10:14:41 -0700 Subject: [PATCH] perf: LogEnabled inline more --- opentelemetry-sdk/benches/log_enabled.rs | 5 +++-- opentelemetry-sdk/src/logs/concurrent_log_processor.rs | 1 + opentelemetry-sdk/src/logs/simple_log_processor.rs | 1 + 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/opentelemetry-sdk/benches/log_enabled.rs b/opentelemetry-sdk/benches/log_enabled.rs index 8962fff4d0..c285bdd044 100644 --- a/opentelemetry-sdk/benches/log_enabled.rs +++ b/opentelemetry-sdk/benches/log_enabled.rs @@ -5,8 +5,8 @@ Total Number of Cores:   14 (10 performance and 4 efficiency) | Test | Average time| |---------------------------------------------|-------------| - | exporter_disabled_concurrent_processor | 1.0 ns | - | exporter_disabled_simple_processor | 4.5 ns | + | exporter_disabled_concurrent_processor | 980 ps | + | exporter_disabled_simple_processor | 4.3 ns | */ // cargo bench --bench log_enabled --features="spec_unstable_logs_enabled,experimental_logs_concurrent_log_processor" @@ -33,6 +33,7 @@ impl LogExporter for NoopExporter { Ok(()) } + #[inline] fn event_enabled( &self, _level: opentelemetry::logs::Severity, diff --git a/opentelemetry-sdk/src/logs/concurrent_log_processor.rs b/opentelemetry-sdk/src/logs/concurrent_log_processor.rs index a8e5c66614..d77a0cc6a0 100644 --- a/opentelemetry-sdk/src/logs/concurrent_log_processor.rs +++ b/opentelemetry-sdk/src/logs/concurrent_log_processor.rs @@ -48,6 +48,7 @@ impl LogProcessor for SimpleConcurrentLogProcessor { } #[cfg(feature = "spec_unstable_logs_enabled")] + #[inline] fn event_enabled( &self, level: opentelemetry::logs::Severity, diff --git a/opentelemetry-sdk/src/logs/simple_log_processor.rs b/opentelemetry-sdk/src/logs/simple_log_processor.rs index 4f12f553d6..604d00e25c 100644 --- a/opentelemetry-sdk/src/logs/simple_log_processor.rs +++ b/opentelemetry-sdk/src/logs/simple_log_processor.rs @@ -134,6 +134,7 @@ impl LogProcessor for SimpleLogProcessor { } #[cfg(feature = "spec_unstable_logs_enabled")] + #[inline] fn event_enabled( &self, level: opentelemetry::logs::Severity,