From 204121d69ca23a062c881958cb5177c3b2301ce9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Antonsson?= <bjorn.antonsson@datadoghq.com>
Date: Thu, 3 Apr 2025 17:09:14 +0200
Subject: [PATCH] chore: fix clippy lint errors for rust 1.86.0

---
 opentelemetry-sdk/src/metrics/instrument.rs | 6 +++---
 opentelemetry-sdk/src/metrics/view.rs       | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/opentelemetry-sdk/src/metrics/instrument.rs b/opentelemetry-sdk/src/metrics/instrument.rs
index e1e7e7b45c..cd97b0755e 100644
--- a/opentelemetry-sdk/src/metrics/instrument.rs
+++ b/opentelemetry-sdk/src/metrics/instrument.rs
@@ -130,10 +130,10 @@ impl Instrument {
 
     /// empty returns if all fields of i are their default-value.
     pub(crate) fn is_empty(&self) -> bool {
-        self.name == ""
-            && self.description == ""
+        self.name.is_empty()
+            && self.description.is_empty()
             && self.kind.is_none()
-            && self.unit == ""
+            && self.unit.is_empty()
             && self.scope == InstrumentationScope::default()
     }
 
diff --git a/opentelemetry-sdk/src/metrics/view.rs b/opentelemetry-sdk/src/metrics/view.rs
index ed67fe9de2..ac89606fd0 100644
--- a/opentelemetry-sdk/src/metrics/view.rs
+++ b/opentelemetry-sdk/src/metrics/view.rs
@@ -110,7 +110,7 @@ pub fn new_view(criteria: Instrument, mask: Stream) -> MetricResult<Box<dyn View
     let contains_wildcard = criteria.name.contains(['*', '?']);
 
     let match_fn: Box<dyn Fn(&Instrument) -> bool + Send + Sync> = if contains_wildcard {
-        if mask.name != "" {
+        if !mask.name.is_empty() {
             // TODO - The error is getting lost here. Need to return or log.
             return Ok(Box::new(empty_view));
         }