Skip to content

Conversation

@cijothomas
Copy link
Member

Continuing from #2905

There will be further cleanups for MetricError to the point it'll be completely removed. All places where it is required has been modified to use the OTelSdkResult. The remaining usages are only required for "Views", which is experimental features, so the MetricError can remain public only when that feature is enabled, otherwise non-public.
This helps cleanup unnecessary public API from the Metrics Sdk, and gets one more step closer to declaring Metrics Sdk as stable.

@cijothomas cijothomas requested a review from a team as a code owner April 7, 2025 00:44
@codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.3%. Comparing base (df26240) to head (c069493).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-otlp/src/exporter/http/mod.rs 0.0% 6 Missing ⚠️
opentelemetry-otlp/src/exporter/http/metrics.rs 0.0% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2906   +/-   ##
=====================================
  Coverage   81.3%   81.3%           
=====================================
  Files        126     126           
  Lines      24256   24253    -3     
=====================================
  Hits       19735   19735           
+ Misses      4521    4518    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

};
use crate::{ExportConfig, Protocol, OTEL_EXPORTER_OTLP_ENDPOINT, OTEL_EXPORTER_OTLP_HEADERS};
use http::{HeaderName, HeaderValue, Uri};
#[cfg(feature = "http-json")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be internal-logs feature?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this is only used when json serialization failed, and it was complaining about unused imports without this!

@cijothomas cijothomas merged commit d4c6467 into open-telemetry:main Apr 8, 2025
23 of 24 checks passed
@cijothomas cijothomas deleted the cijothomas/metric-error-2 branch April 8, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants