-
Notifications
You must be signed in to change notification settings - Fork 600
fix: cleanup MetricError #2906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cleanup MetricError #2906
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2906 +/- ##
=====================================
Coverage 81.3% 81.3%
=====================================
Files 126 126
Lines 24256 24253 -3
=====================================
Hits 19735 19735
+ Misses 4521 4518 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gruebel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
| }; | ||
| use crate::{ExportConfig, Protocol, OTEL_EXPORTER_OTLP_ENDPOINT, OTEL_EXPORTER_OTLP_HEADERS}; | ||
| use http::{HeaderName, HeaderValue, Uri}; | ||
| #[cfg(feature = "http-json")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be internal-logs feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, this is only used when json serialization failed, and it was complaining about unused imports without this!
Continuing from #2905
There will be further cleanups for
MetricErrorto the point it'll be completely removed. All places where it is required has been modified to use theOTelSdkResult. The remaining usages are only required for "Views", which is experimental features, so theMetricErrorcan remain public only when that feature is enabled, otherwise non-public.This helps cleanup unnecessary public API from the Metrics Sdk, and gets one more step closer to declaring Metrics Sdk as stable.