-
Notifications
You must be signed in to change notification settings - Fork 600
fix: fix trace id in logs when using set_parent nested in a trace span #2924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2924 +/- ##
=====================================
Coverage 81.1% 81.2%
=====================================
Files 126 126
Lines 24794 24839 +45
=====================================
+ Hits 20131 20173 +42
- Misses 4663 4666 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @SF-Zhou thanks for opening the PR! |
Sure. The description of the PR has been updated. |
|
@bantonsson I think your eyes on this would be helpful! |
cijothomas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Requesting changing to address the comment below:
See https://github.com/open-telemetry/opentelemetry-rust/pull/2924/files#r2044837776
Done. |
|
@cijothomas could you please review the updates when convenient? If everything looks good, we can proceed to merge. |
open-telemetry#2924) Co-authored-by: Cijo Thomas <[email protected]>
Fixes #2824.
Changes
When using distributed tracing and calling
set_parentto set the context, the currently obtainedtrace_idwas incorrect. This PR fixes this issue.This fix has been validated in online production environments. For users with the same requirements, they can temporarily opt to use the patched
opentelemetry-appender-tracing-patchedcrate.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes