Skip to content

Conversation

@Henauxg
Copy link
Contributor

@Henauxg Henauxg commented Apr 17, 2025

Changes

Fixed the opentelemtry-otlp quickstart guides for HTTP & gRPC

HTTP:

  • Added missing call to global::set_tracer_provider

gRPC:

  • Fixed the main sample to use [tokio:main] and to call global::set_tracer_provider
  • Added a small sample using gRPC without [tokio:main] (based on opentelemtry-otlp/examples/basic-otlp)

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (NA)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes (NA)
  • Changes in public API reviewed (NA)

Tests

cargo test --all fails on test build_tonic but this is also the case on main

@Henauxg Henauxg requested a review from a team as a code owner April 17, 2025 14:16
@codecov
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.3%. Comparing base (9cdc931) to head (3c466f2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2933     +/-   ##
=======================================
- Coverage   81.3%   81.3%   -0.1%     
=======================================
  Files        126     126             
  Lines      24254   24254             
=======================================
- Hits       19736   19733      -3     
- Misses      4518    4521      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Henauxg Henauxg changed the title docs: fix the gRPC Transport quickstart guide docs: fix the HTTP and gRPC transports quickstart guides Apr 17, 2025
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
If you have more bandwidth, please continue improving this doc in future PRs.
Some missing things:

  1. Use batch_processor instead of simple. (or mention in code comment about batch being the production recommendation)
  2. Show tracerProvider shutdown at the end.

(Then extend the doc to logs, metrics)

@cijothomas cijothomas merged commit b5d31f1 into open-telemetry:main Apr 17, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants