ci: Run benchmarks on main on the new oracle dedicated workers #2942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2942 +/- ##
=====================================
Coverage 81.1% 81.1%
=====================================
Files 126 126
Lines 24954 24954
=====================================
Hits 20255 20255
Misses 4699 4699 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trask
reviewed
Apr 23, 2025
.github/workflows/benchmark.yml
Outdated
| # TODO - temporarily move main to the shared workers, until we've resolved the instance setup issue | ||
| # | ||
| # TODO - temporarily use self-hosted to get shared-worker environment going | ||
| runs-on: 'self-hosted' |
Member
There was a problem hiding this comment.
PR run appears to be against a special branch:
Job defined at: open-telemetry/opentelemetry-rust/.github/workflows/benchmark.yml@refs/pull/2942/merge
can you add dependabot/scottgerring/benchmark-fix to the workflow definition above?
on:
pull_request:
push:
branches:
- main
- dependabot/scottgerring/benchmark-fix
Member
Author
|
The story so far:
Docker is also missing, so we can't wrap things up that way. |
…ring/benchmark-fix' into dependabot/scottgerring/benchmark-fix
Benchmark for 28d605bClick to view benchmark
|
Member
Author
|
@cijothomas @trask this now works for our new bare-metal runner --> forced to run on bare-metal on this branch, but triggers now only on pushes to as well as the github pooled workers for PRs that are tagged with |
scottgerring
changed the title
Benchmark for 4aa757fClick to view benchmark
|
cijothomas
reviewed
Jun 20, 2025
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| fetch-depth: 10 # Fetch current commit and its parent | ||
| fetch-depth: 10 # Fetch a bit of history so we can do perf diffs |
Member
There was a problem hiding this comment.
the perf diff is against main ? or with the previous commit in the PR?
cijothomas
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on fixing the dedicated benchmark runner setup. This supercedes #2840 as it needs to be setup from a branch within the repo and not a fork.