Skip to content

Conversation

@berkus
Copy link
Contributor

@berkus berkus commented Jul 2, 2025

Changes

Replace unmaintaned dependency with newer, faster, maintained version.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@berkus berkus requested a review from a team as a code owner July 2, 2025 15:37
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 2, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: berkus / name: Berkus Decker (65d36dc)

@codecov
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.0%. Comparing base (8d46c40) to head (65d36dc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3053   +/-   ##
=====================================
  Coverage   80.0%   80.0%           
=====================================
  Files        126     126           
  Lines      21879   21879           
=====================================
  Hits       17519   17519           
  Misses      4360    4360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gruebel gruebel changed the title 🚨 Switch from unmaintained hex dependency to const-hex chore: Switch from unmaintained hex dependency to const-hex Jul 2, 2025
@berkus
Copy link
Contributor Author

berkus commented Jul 2, 2025

how to fix easycla? looks broken, i signed it but nothing changed

Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, change looks good. @cijothomas do you know what to do with the CLA?

@cijothomas cijothomas closed this Jul 2, 2025
@cijothomas cijothomas reopened this Jul 2, 2025
@cijothomas
Copy link
Member

/easycla

@lalitb
Copy link
Member

lalitb commented Jul 6, 2025

@berkus - Can you verify that you used the email address associated with your GitHub account when signing the CLA? It's possible you may have accidentally used a different email address.

@lalitb
Copy link
Member

lalitb commented Jul 7, 2025

@berkus - Can you verify that you used the email address associated with your GitHub account when signing the CLA? It's possible you may have accidentally used a different email address.

Ok, seems you have used multiple Github users in this PR - at least the commit was done using different user:

image

@berkus
Copy link
Contributor Author

berkus commented Jul 9, 2025

Ok, let me rewrite this commit.

@berkus berkus force-pushed the fix/unmaintaned-dependency branch from c6c9a11 to 6d5d6f8 Compare July 9, 2025 11:11
@berkus
Copy link
Contributor Author

berkus commented Jul 9, 2025

Now it looks green!

@berkus berkus force-pushed the fix/unmaintaned-dependency branch from 6d5d6f8 to 65d36dc Compare July 9, 2025 11:14
@cijothomas cijothomas merged commit 5e447d0 into open-telemetry:main Jul 9, 2025
27 of 28 checks passed
@berkus berkus deleted the fix/unmaintaned-dependency branch July 14, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants