feat: Add Clone implementation to SdkLogger for API consistency with SdkTracer #3072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the inconsistency between
SdkLoggerandSdkTracerby addingCloneimplementation toSdkLogger.Problem
Currently,
SdkTracerimplementsClonebutSdkLoggerdoes not, creating an inconsistent API experience:This forces users to wrap
SdkLoggerinArcor similar constructs when they need to share it across multiple contexts.Solution
Added
Cloneto the derive macro forSdkLogger. This is safe because both fields in the struct already implementClone:InstrumentationScopeimplementsCloneSdkLoggerProviderimplementsCloneChanges
SdkLoggerfrom#[derive(Debug)]to#[derive(Debug, Clone)]After this change
This is a non-breaking change that improves API consistency and developer experience.
Fixes #3058.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.