Skip to content

Conversation

@korniltsev
Copy link
Contributor

@korniltsev korniltsev commented Jul 18, 2025

Changes

This change allows setting up a profiles collector client. This will allow to send profiles to collectors from Rust.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@codecov
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.1%. Comparing base (0e3511e) to head (828a567).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3077     +/-   ##
=======================================
- Coverage   80.1%   80.1%   -0.1%     
=======================================
  Files        126     126             
  Lines      21949   21949             
=======================================
- Hits       17603   17599      -4     
- Misses      4346    4350      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@korniltsev korniltsev marked this pull request as ready for review July 18, 2025 09:41
@korniltsev korniltsev requested a review from a team as a code owner July 18, 2025 09:41
@lalitb lalitb requested a review from Copilot July 21, 2025 16:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for generating Rust protobuf bindings for the OpenTelemetry profiles collector service, enabling Rust applications to send profiling data to OpenTelemetry collectors.

  • Adds profiles collector service proto file to the build configuration
  • Generates new tonic client and server implementations for the ProfilesService
  • Updates module structure to properly expose the profiles collector API
  • Corrects module naming inconsistency for profiles v1development

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
opentelemetry-proto/tests/grpc_build.rs Adds profiles_service.proto to the list of files for tonic generation
opentelemetry-proto/src/proto/tonic/opentelemetry.proto.collector.profiles.v1development.rs Generated tonic client/server code for ProfilesService with export functionality
opentelemetry-proto/src/proto.rs Adds profiles collector module and fixes profiles module naming consistency
opentelemetry-proto/CHANGELOG.md Documents the addition of profiles collector proto generation

@lalitb lalitb merged commit c5fde17 into open-telemetry:main Jul 21, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants