perf: Compare different span creation scenarios #3079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3079 +/- ##
=====================================
Coverage 80.1% 80.1%
=====================================
Files 126 126
Lines 21957 21957
=====================================
Hits 17604 17604
Misses 4353 4353 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lalitb
reviewed
Jul 23, 2025
| // This is similar to the simple span creation, but also does the job of activating | ||
| // the span in the current context. | ||
| // It is slower than other approaches of activation due to the fact that | ||
| // context activation is done, irrespective of sampling decision. |
Member
There was a problem hiding this comment.
Also, I remember you mentioned cost of mutex lock invoked here? Do we need to mention that in comment?
Member
Author
There was a problem hiding this comment.
will do in the next iteration. Everytime span is retrieved from Context, this mutex gets invoked in all subsequent Span operations.
lalitb
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left existing benches untouched for now. Will consolidate all in a future date.
This is primarily comparing the costs of various span creation. Given there are multiple ways, we need to document the right choices for each scenario (or eliminate the choices). These benches are just starting point.