Skip to content

chore: modify BatchLogProcessor method to accept max_export_size: usize parameter instead of config: &BatchConfig #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025
Merged

chore: modify BatchLogProcessor method to accept max_export_size: usize parameter instead of config: &BatchConfig #3119

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c99654
chore: nit rename to batchlogprocessor
cijothomas Aug 5, 2025
0a37b9f
Merge branch 'main' into cijothomas/blp-nits
lalitb Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions opentelemetry-sdk/src/logs/batch_log_processor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ impl BatchLogProcessor {
logs: &mut Vec<LogsData>,
last_export_time: &mut Instant,
current_batch_size: &AtomicUsize,
config: &BatchConfig,
max_export_size: usize,
) -> OTelSdkResult
where
E: LogExporter + Send + Sync + 'static,
Expand All @@ -373,7 +373,7 @@ impl BatchLogProcessor {
// Get upto `max_export_batch_size` amount of logs log records from the channel and push them to the logs vec
while let Ok(log) = logs_receiver.try_recv() {
logs.push(log);
if logs.len() == config.max_export_batch_size {
if logs.len() == max_export_size {
break;
}
}
Expand Down Expand Up @@ -409,7 +409,7 @@ impl BatchLogProcessor {
&mut logs,
&mut last_export_time,
&current_batch_size,
&config,
max_export_batch_size,
);
}
Ok(BatchMessage::ForceFlush(sender)) => {
Expand All @@ -420,7 +420,7 @@ impl BatchLogProcessor {
&mut logs,
&mut last_export_time,
&current_batch_size,
&config,
max_export_batch_size,
);
let _ = sender.send(result);
}
Expand All @@ -432,7 +432,7 @@ impl BatchLogProcessor {
&mut logs,
&mut last_export_time,
&current_batch_size,
&config,
max_export_batch_size,
);
let _ = exporter.shutdown();
let _ = sender.send(result);
Expand Down Expand Up @@ -460,7 +460,7 @@ impl BatchLogProcessor {
&mut logs,
&mut last_export_time,
&current_batch_size,
&config,
max_export_batch_size,
);
}
Err(RecvTimeoutError::Disconnected) => {
Expand Down
Loading