Skip to content

Commit 20b87ec

Browse files
pellaredlmolkovacarlosalberto
authored
Changes of disabled config MUST be eventually visible (#4645)
Fixes #4643 ## What Clarify that changes of disabled config MUST be eventually visible. ## Why Currently, the implementation that would not never synchronize modification and access to `disabled` config are compliant with the specification. This is not correct as then the user may never see the changes when the configuration changes. Per #4645 (comment) Languages remain free to document and implement their own refresh/caching behaviors as long as they are eventually consistent. --------- Co-authored-by: Liudmila Molkova <[email protected]> Co-authored-by: Carlos Alberto Cortez <[email protected]>
1 parent 1c659ab commit 20b87ec

File tree

4 files changed

+16
-3
lines changed

4 files changed

+16
-3
lines changed

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,19 @@ release.
1111

1212
### Traces
1313

14+
- Changes of `TracerConfig.disabled` MUST be eventually visible.
15+
([#4645](https://github.com/open-telemetry/opentelemetry-specification/pull/4645))
16+
1417
### Metrics
1518

19+
- Changes of `MeterConfig.disabled` MUST be eventually visible.
20+
([#4645](https://github.com/open-telemetry/opentelemetry-specification/pull/4645))
21+
1622
### Logs
1723

24+
- Changes of `LoggerConfig.disabled` MUST be eventually visible.
25+
([#4645](https://github.com/open-telemetry/opentelemetry-specification/pull/4645))
26+
1827
### Baggage
1928

2029
### Profiles

specification/logs/sdk.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,7 @@ It consists of the following parameters:
217217

218218
It is not necessary for implementations to ensure that changes to any of these
219219
parameters are immediately visible to callers of `Enabled`.
220+
However, the changes MUST be eventually visible.
220221

221222
### Emit a LogRecord
222223

specification/metrics/sdk.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1013,6 +1013,7 @@ aggregation when no matching views match the instrument.
10131013

10141014
It is not necessary for implementations to ensure that changes
10151015
to `MeterConfig.disabled` are immediately visible to callers of `Enabled`.
1016+
However, the changes MUST be eventually visible.
10161017

10171018
## Attribute limits
10181019

specification/trace/sdk.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -207,9 +207,11 @@ It consists of the following parameters:
207207

208208
The value of `disabled` MUST be used to resolve whether a `Tracer`
209209
is [Enabled](./api.md#enabled). If `disabled` is `true`, `Enabled`
210-
returns `false`. If `disabled` is `false`, `Enabled` returns `true`. It is not
211-
necessary for implementations to ensure that changes to `disabled` are
212-
immediately visible to callers of `Enabled`.
210+
returns `false`. If `disabled` is `false`, `Enabled` returns `true`.
211+
212+
It is not necessary for implementations to ensure that changes to `disabled`
213+
are immediately visible to callers of `Enabled`.
214+
However, the changes MUST be eventually visible.
213215

214216
### Enabled
215217

0 commit comments

Comments
 (0)