Commit 74c6267
authored
Add resource detector name (#4461)
All SDK extension plugin interfaces are referred to by name in
declarative config.
For SDK extension plugin interfaces like exporters, processors, metric
readers, we have well-defined sets of built-in implementations. E.g.:
- span exporter: otlp, otlp_file, console, zipkin
- metric exporter: otlp, otlp_file, console
- log exporter: otlp, otlp_file, console
- span processor: simple, batch
- metric reader: periodic, prometheus
- log processor: simple, batch
These well-defined names provide obvious choices to name things in the
declarative config JSON schema.
Resource detectors are currently much more open ended, with no defined
list of built-in detectors. This is a problem for declarative config
because we want to have a config story where you can plug the same YAML
into different SDK language implementation and get the same behavior.
Without defining this list, users will have to carefully lookup
language-specific resource detector names and modify their YAML
accordingly. Yikes.
This PR solves this by:
- Establishing that resource detectors have a name, used for reference
in configuration (where declarative config is the primary use case but
other config solutions could similarly use the name)
- Provide normative language for naming resource detectors according the
root namespace of attributes they (e.g. `os` resource detector populates
`os.*` attributes)
- Carve out a list of reserved resource detector names, which should
become standard in SDK-implementations
See also
[https://github.com/open-telemetry/opentelemetry-configuration/pull/188](https://github.com/open-telemetry/opentelemetry-configuration/pull/188)
for a reference at how these resource detector names are used in
declarative configuration.
cc @open-telemetry/configuration-approvers1 parent 4f82878 commit 74c6267
2 files changed
+44
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
22 | 25 | | |
23 | 26 | | |
24 | 27 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
131 | 171 | | |
132 | 172 | | |
133 | 173 | | |
| |||
0 commit comments