Skip to content

Commit 74eb817

Browse files
committed
Add spec for AlwaysRecord sampler
1 parent 8d6e875 commit 74eb817

File tree

2 files changed

+21
-0
lines changed

2 files changed

+21
-0
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ release.
1111

1212
### Traces
1313

14+
- Add spec for `AlwaysRecord` sampler
15+
([#4699](https://github.com/open-telemetry/opentelemetry-specification/pull/4699))
16+
1417
### Metrics
1518

1619
- `AlignedHistogramBucketExemplarReservoir` SHOULD use a time-weighted algorithm.

specification/trace/sdk.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ weight: 3
4141
- [Compatibility warnings for `ProbabilitySampler`](#compatibility-warnings-for-probabilitysampler)
4242
+ [ParentBased](#parentbased)
4343
+ [JaegerRemoteSampler](#jaegerremotesampler)
44+
+ [AlwaysRecord](#alwaysrecord)
4445
+ [CompositeSampler](#compositesampler)
4546
- [ComposableSampler](#composablesampler)
4647
* [GetSamplingIntent](#getsamplingintent)
@@ -603,6 +604,23 @@ The following configuration properties should be available when creating the sam
603604
[jaeger-remote-sampling-api]: https://www.jaegertracing.io/docs/1.41/architecture/apis/#remote-sampling-configuration-stable
604605
[jaeger-adaptive-sampling]: https://www.jaegertracing.io/docs/1.41/architecture/sampling/#adaptive-sampling
605606

607+
#### AlwaysRecord
608+
609+
**Status**: [Development](../document-status.md)
610+
611+
This is a sampler decorator. `AlwaysRecord` helps to have spans between
612+
always be processed by `SpanProcessor`s. It returns the following given
613+
a sampled flag from the root sampler:
614+
615+
* Root sampler returns `DROP` -> AlwaysRecord returns `RECORD_ONLY`
616+
* Root sampler returns `RECORD_ONLY` -> AlwaysRecord returns `RECORD_ONLY`
617+
* Root sampler returns `RECORD_AND_SAMPLE` -> AlwaysRecord returns `RECORD_AND_SAMPLE`
618+
619+
Required parameters:
620+
621+
* `root(Sampler)` - A delegate sampler called to determine whether a span
622+
is sampled or dropped
623+
606624
#### CompositeSampler
607625

608626
**Status**: [Development](../document-status.md)

0 commit comments

Comments
 (0)