Skip to content

Commit a1d20b9

Browse files
yurishkuropellared
andauthored
Remove restriction that sampler description is immutable (#4137)
Fixes #2095 ## Changes State that sampler description can change over time. Provide examples. --------- Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Robert Pająk <[email protected]>
1 parent 32bad98 commit a1d20b9

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ release.
1111

1212
### Traces
1313

14+
- Remove restriction that sampler description is immutable.
15+
([#4137](https://github.com/open-telemetry/opentelemetry-specification/pull/4137))
16+
1417
### Metrics
1518

1619
### Logs

specification/trace/sdk.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,9 @@ Returns the sampler name or short description with the configuration. This may
364364
be displayed on debug pages or in the logs. Example:
365365
`"TraceIdRatioBased{0.000100}"`.
366366

367-
Description MUST NOT change over time and caller can cache the returned value.
367+
Description MAY change over time, for example, if the sampler supports dynamic
368+
configuration or otherwise adjusts its parameters.
369+
Callers SHOULD NOT cache the returned value.
368370

369371
### Built-in samplers
370372

0 commit comments

Comments
 (0)