You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: oteps/0016-named-tracers.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -50,7 +50,7 @@ Meter meter = OpenTelemetry.getMeterProvider().getMeter("io.opentelemetry.contri
50
50
51
51
These factories (`TracerProvider` and `MeterProvider`) replace the global `Tracer` / `Meter` singleton objects as ubiquitous points to request Tracer and Meter instances.
52
52
53
-
The _name_ used to create a Tracer or Meter must identify the _instrumentation_ libraries (also referred to as _integrations_) and not the library being instrumented. These instrumentation libraries could be libraries developed in an OpenTelemetry repository, a 3rd party implementation, or even auto-injected code (see [OpenTelemetry Without Manual Instrumentation OTEP](https://github.com/open-telemetry/oteps/blob/main/text/0001-telemetry-without-manual-instrumentation.md)). See also the examples for identifiers at the end.
53
+
The _name_ used to create a Tracer or Meter must identify the _instrumentation_ libraries (also referred to as _integrations_) and not the library being instrumented. These instrumentation libraries could be libraries developed in an OpenTelemetry repository, a third-party implementation, or even auto-injected code (see [OpenTelemetry Without Manual Instrumentation OTEP](https://github.com/open-telemetry/oteps/blob/main/text/0001-telemetry-without-manual-instrumentation.md)). See also the examples for identifiers at the end.
54
54
If a library (or application) has instrumentation built-in, it is both the instrumenting and instrumented library and should pass its own name here. In all other cases (and to distinguish them from that case), the distinction between instrumenting and instrumented library is very important. For example, if an HTTP library `com.example.http` is instrumented by either `io.opentelemetry.contrib.examplehttp`, then it is important that the Tracer is not named `com.example.http`, but `io.opentelemetry.contrib.examplehttp` after the actual instrumentation library.
55
55
56
56
If no name (null or empty string) is specified, following the suggestions in ["error handling proposal"](https://github.com/open-telemetry/opentelemetry-specification/pull/153), a "smart default" will be applied and a default Tracer / Meter implementation is returned.
Copy file name to clipboardExpand all lines: oteps/0119-standard-system-metrics.md
+3-3Lines changed: 3 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -6,7 +6,7 @@ This OTEP is largely based on the existing implementation in the OpenTelemetry C
6
6
7
7
## Trade-offs and mitigations
8
8
9
-
When naming a metric instrument, there is a trade-off between discoverability and ambiguity. For example, a metric called `system.cpu.load_average` is very discoverable, but the meaning of this metric is ambiguous. [Load average](https://en.wikipedia.org/wiki/Load_(computing)) is well defined on Unix, but is not a standard metric on Windows. While discoverability is important, names must be unambiguous.
9
+
When naming a metric instrument, there is a trade-off between discoverability and ambiguity. For example, a metric called `system.cpu.load_average` is very discoverable, but the meaning of this metric is ambiguous. [Load average](https://en.wikipedia.org/wiki/Load_(computing)) is well defined on UNIX, but is not a standard metric on Windows. While discoverability is important, names must be unambiguous.
10
10
11
11
## Prior art
12
12
@@ -151,5 +151,5 @@ Some programming languages have multiple runtime environments that vary signific
151
151
- Should the individual runtimes have their specific naming conventions in the spec?
152
152
- Is it OK to include instruments specific to an OS (or OS family) under a top-level prefix, as long as they are unambiguous? For example, naming inode related instruments, which of the below is preferred?
153
153
1. Top level: `system.filesystem.inodes.*`
154
-
2.Unix family level: `system.unix.filesystem.inodes.*`
155
-
3. One for each Unix OS: `system.linux.filesystem.inodes.*`, `system.freebsd.filesystem.inodes.*`, `system.netbsd.filesystem.inodes.*`, etc.
154
+
2.UNIX family level: `system.unix.filesystem.inodes.*`
155
+
3. One for each UNIX OS: `system.linux.filesystem.inodes.*`, `system.freebsd.filesystem.inodes.*`, `system.netbsd.filesystem.inodes.*`, etc.
Copy file name to clipboardExpand all lines: oteps/0122-otlp-http-json.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -19,7 +19,7 @@ This is a proposal to add HTTP Transport extension supporting JSON serialization
19
19
20
20
## Motivation
21
21
22
-
Protobuf is a relatively big dependency, which some clients are not willing to take. For example, WebJS, iOS/Android (in some scenarios, the size of the installation package is limited, do not want to introduce protobuf dependencies). Plain JSON is a smaller dependency and is builtin the standard libraries of many programming languages.
22
+
Protobuf is a relatively big dependency, which some clients are not willing to take. For example, WebJS, iOS/Android (in some scenarios, the size of the installation package is limited, do not want to introduce protobuf dependencies). Plain JSON is a smaller dependency and is built-in the standard libraries of many programming languages.
Copy file name to clipboardExpand all lines: oteps/0199-support-elastic-common-schema-in-opentelemetry.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -161,7 +161,7 @@ Example of a NGINX Access Log entry structured with ECS
161
161
| Category | <ahref="../specification/logs/data-model.md#log-and-event-record-definition">OTel Logs and Event Record</a> (all or a subset of <ahref="https://protobuf.dev/programming-guides/proto3/">GRPC data types</a>) | <ahref="https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/field-data-types">ECS Data Types</a> |
| Numbers | number | <ahref="https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/number">long</a>, <ahref="https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/number">double</a>, <ahref="https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/number">scaled_float</a>, <ahref="https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/boolean">boolean</a>… |
166
166
| Objects | uint32, uint64… | <ahref="https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/object">object</a> (JSON object), <ahref="https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/flattened">flattened</a> (An entire JSON object as a single field value) |
167
167
| Structured Objects | No complex semantic data type specified for the moment (e.g. string is being used for ip addresses rather than having an "ip" data structure in OTel). <br/> Note that OTel supports arrays and nested objects. | <ahref="https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/ip">ip</a>, <ahref="https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/geo-point">geo_point</a>, <ahref="https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/geo-shape">geo_shape</a>, <ahref="https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/version">version</a>, <ahref="https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/range">long_range</a>, <ahref="https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/range">date_range</a>, <ahref="https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/range">ip_range</a> |
@@ -185,7 +185,7 @@ As the markdown code of the tables is hard to read and maintain with very long l
185
185
</td>
186
186
</tr>
187
187
<tr>
188
-
<td><ahref="../specification/logs/data-model.md#log-and-event-record-definition">Timestamp</a> (uint64 nanoseconds since Unix epoch)
188
+
<td><ahref="../specification/logs/data-model.md#log-and-event-record-definition">Timestamp</a> (uint64 nanoseconds since UNIX epoch)
Copy file name to clipboardExpand all lines: oteps/0225-configuration.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -299,7 +299,7 @@ In choosing to recommend JSON schema, the working group looked at the following
299
299
* [Cue](https://cuelang.org/) - A promising simpler language to define a schema, the working group decided against CUE because:
300
300
* Tooling available for validating CUE files in languages outside of Go were limited.
301
301
* Familiarity and learning curve would create problems for both users and contributors of OpenTelemetry.
302
-
* [Protobuf](https://protobuf.dev) - With protobuf already used heavily in OpenTelemetry, the format was worth investigating as an option to define the schema. The working group decided against Protobuf because:
302
+
* [Protobuf](https://protobuf.dev) - With protobuf already used heavily in OpenTelemetry, the format was worth investigating as an option to define the schema. The working group decided against protobuf because:
303
303
* Validation errors are the result of serialization errors which can be difficult to interpret.
304
304
* Limitations in the schema definition language result in poor ergonomics if type safety is to be retained.
0 commit comments