Skip to content

Commit ca2a0d4

Browse files
Use PR number as OTEP id. (#4292)
Co-authored-by: Armin Ruech <[email protected]>
1 parent f599c40 commit ca2a0d4

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

oteps/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,12 @@ For example, an OTEP proposing configurable sampling *and* various samplers shou
5353

5454
- First, [fork](https://help.github.com/en/articles/fork-a-repo) this repo.
5555
- Copy [`0000-template.md`](./0000-template.md) to `0000-my-OTEP.md`, where `my-OTEP` is a title relevant to your proposal, and `0000` is the OTEP ID.
56+
Leave the number as is for now. Once a Pull Request is made, update this ID to match the PR ID.
5657
- Fill in the template. Put care into the details: It is important to present convincing motivation, demonstrate an understanding of the design's impact, and honestly assess the drawbacks and potential alternatives.
5758

5859
### Submitting the OTEP
5960

60-
- An OTEP is `proposed` by posting it as a PR.
61+
- An OTEP is `proposed` by posting it as a PR. Once the PR is created, update the OTEP file name to use the PR ID as the OTEP ID.
6162
- An OTEP is `approved` when four reviewers github-approve the PR. The OTEP is then merged.
6263
- If an OTEP is `rejected` or `withdrawn`, the PR is closed. Note that these OTEPs submissions are still recorded, as GitHub retains both the discussion and the proposal, even if the branch is later deleted.
6364
- If an OTEP discussion becomes long, and the OTEP then goes through a major revision, the next version of the OTEP can be posted as a new PR, which references the old PR. The old PR is then closed. This makes OTEP review easier to follow and participate in.

0 commit comments

Comments
 (0)