Skip to content

Commit e4c977a

Browse files
pellaredtraskcarlosalberto
authored
Stabilize SDK and No-Op Logger.Enabled (#4536)
This part of the specification can be stabilized. It primarily defines how the SDK should respond to `Logger.Enabled` calls. I believe adding new rules in this context should not be considered breaking changes. Notice that `Logger.Enabled` API has been already stabilized in #4463. --------- Co-authored-by: Trask Stalnaker <[email protected]> Co-authored-by: Carlos Alberto Cortez <[email protected]>
1 parent ccb4d12 commit e4c977a

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ release.
2020

2121
- Stabilize `Event Name` parameter of `Logger.Enabled`.
2222
([#4534](https://github.com/open-telemetry/opentelemetry-specification/pull/4534))
23+
- Stabilize SDK and No-Op `Logger.Enabled`.
24+
([#4536](https://github.com/open-telemetry/opentelemetry-specification/pull/4536))
2325

2426
### Baggage
2527

specification/logs/noop.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ linkTitle: No-Op
44

55
# Logs API No-Op Implementation
66

7-
**Status**: [Stable](../document-status.md), except where otherwise specified
7+
**Status**: [Stable](../document-status.md)
88

99
<details>
1010
<summary> Table of Contents </summary>
@@ -59,6 +59,4 @@ for [emitting LogRecords](./api.md#emit-a-logrecord).
5959

6060
### Enabled
6161

62-
**Status**: [Development](../document-status.md)
63-
6462
MUST always return `false`.

specification/logs/sdk.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -200,13 +200,13 @@ the implementation SHOULD set it equal to the current time.
200200

201201
### Enabled
202202

203-
**Status**: [Development](../document-status.md)
204-
205203
`Enabled` MUST return `false` when either:
206204

207205
- there are no registered [`LogRecordProcessors`](#logrecordprocessor),
208-
- `Logger` is disabled ([`LoggerConfig.disabled`](#loggerconfig) is `true`),
209-
- all registered `LogRecordProcessors` implement [`Enabled`](#enabled-1),
206+
- **Status**: [Development](../document-status.md) - `Logger` is disabled
207+
([`LoggerConfig.disabled`](#loggerconfig) is `true`),
208+
- **Status**: [Development](../document-status.md) - all registered
209+
`LogRecordProcessors` implement [`Enabled`](#enabled-1),
210210
and a call to `Enabled` on each of them returns `false`.
211211

212212
Otherwise, it SHOULD return `true`.

0 commit comments

Comments
 (0)