Skip to content

Commit fbcd7a3

Browse files
Update Probability Sampler description to remove "ratio-based" reference (#4674)
## Changes When reading through #4627, I noticed that the Probability Sampler description still had a reference to ratio-based. I think that entire section may be cut since the clarifications were specifically related to the old name. Also, found a small typo. This seems like a trivial change, so I did not create a new issue nor add a CHANGELOG.md entry. Please let me know if you would rather I make one. * [ ] Related issues: PR #4627 * [ ] Related [OTEP(s)](https://github.com/open-telemetry/oteps) N/A * [ ] Links to the prototypes (when adding or changing features) N/A * [ ] [`CHANGELOG.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md) file updated for non-trivial changes N/A * [ ] [Spec compliance matrix](https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix/template.yaml) updated if necessary N/A
1 parent ec3779c commit fbcd7a3

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

specification/trace/sdk.md

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -512,14 +512,7 @@ OpenTelemetry follows W3C Trace Context Level 2, which specifies 56 bits of rand
512512
The `ProbabilitySampler` sampler MUST ignore the parent `SampledFlag`.
513513
For respecting the parent `SampledFlag`, see the `ParentBased` sampler specified below.
514514

515-
Note that the "ratio-based" part of this Sampler's name implies that
516-
it makes a probability decision directly from the TraceID, even though
517-
it was not originally specified in an exact way. In the present
518-
specification, the Sampler decision is more nuanced: only a portion of
519-
the identifier is used, after checking whether the OpenTelemetry
520-
TraceState field contains an explicit randomness value.
521-
522-
Note that this is a non-composable form of probaiblity
515+
Note that this is a non-composable form of probability
523516
sampler. `ProbabilitySampler` directly implements the SDKs Sampler
524517
API, whereas [`ComposableProbability`](#composableprobability) is the
525518
composable form for use with [`CompositeSampler`](#compositesampler).

0 commit comments

Comments
 (0)