From 923a82bd68d5bfdb63ec399d9214483501e1425b Mon Sep 17 00:00:00 2001 From: Robert Pajak Date: Thu, 11 Sep 2025 17:46:30 +0200 Subject: [PATCH 1/4] Specify changes of disabled MUST be eventually visible --- specification/logs/sdk.md | 8 +++++--- specification/metrics/sdk.md | 1 + specification/trace/sdk.md | 8 +++++--- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/specification/logs/sdk.md b/specification/logs/sdk.md index 94462a56628..d2318745504 100644 --- a/specification/logs/sdk.md +++ b/specification/logs/sdk.md @@ -194,9 +194,11 @@ It consists of the following parameters: The value of `disabled` MUST be used to resolve whether a `Logger` is [Enabled](./api.md#enabled). If `disabled` is `true`, `Enabled` - returns `false`. If `disabled` is `false`, `Enabled` returns `true`. It is not - necessary for implementations to ensure that changes to `disabled` are - immediately visible to callers of `Enabled`. + returns `false`. If `disabled` is `false`, `Enabled` returns `true`. + + It is not necessary for implementations to ensure that changes to `disabled` + are immediately visible to callers of `Enabled`. + However, the changes MUST be eventually visible. ### Emit a LogRecord diff --git a/specification/metrics/sdk.md b/specification/metrics/sdk.md index 71b416a8d28..ebf0eac2384 100644 --- a/specification/metrics/sdk.md +++ b/specification/metrics/sdk.md @@ -1013,6 +1013,7 @@ aggregation when no matching views match the instrument. It is not necessary for implementations to ensure that changes to `MeterConfig.disabled` are immediately visible to callers of `Enabled`. +However, the changes MUST be eventually visible. ## Attribute limits diff --git a/specification/trace/sdk.md b/specification/trace/sdk.md index cd8234f2351..6397189101a 100644 --- a/specification/trace/sdk.md +++ b/specification/trace/sdk.md @@ -207,9 +207,11 @@ It consists of the following parameters: The value of `disabled` MUST be used to resolve whether a `Tracer` is [Enabled](./api.md#enabled). If `disabled` is `true`, `Enabled` - returns `false`. If `disabled` is `false`, `Enabled` returns `true`. It is not - necessary for implementations to ensure that changes to `disabled` are - immediately visible to callers of `Enabled`. + returns `false`. If `disabled` is `false`, `Enabled` returns `true`. + + It is not necessary for implementations to ensure that changes to `disabled` + are immediately visible to callers of `Enabled`. + However, the changes MUST be eventually visible. ### Enabled From f58f6d0b07dd25bba1fb5a74a9c2c3b00d6d4453 Mon Sep 17 00:00:00 2001 From: Robert Pajak Date: Thu, 11 Sep 2025 17:58:40 +0200 Subject: [PATCH 2/4] Add changelog entries --- CHANGELOG.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 893218373ad..b6d81b4d8c0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,10 +11,19 @@ release. ### Traces +- Changes of `TracerrConfig.disabled` MUST be eventually visible. + ([#4645](https://github.com/open-telemetry/opentelemetry-specification/pull/4645)) + ### Metrics +- Changes of `MeterConfig.disabled` MUST be eventually visible. + ([#4645](https://github.com/open-telemetry/opentelemetry-specification/pull/4645)) + ### Logs +- Changes of `LoggerConfig.disabled` MUST be eventually visible. + ([#4645](https://github.com/open-telemetry/opentelemetry-specification/pull/4645)) + ### Baggage ### Profiles From 16002a9efd38a88967ce8799b502c4c35802ce7a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Paj=C4=85k?= Date: Thu, 11 Sep 2025 18:55:38 +0200 Subject: [PATCH 3/4] Update CHANGELOG.md Co-authored-by: Liudmila Molkova --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b6d81b4d8c0..8d4d29e3e80 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,7 @@ release. ### Traces -- Changes of `TracerrConfig.disabled` MUST be eventually visible. +- Changes of `TracerConfig.disabled` MUST be eventually visible. ([#4645](https://github.com/open-telemetry/opentelemetry-specification/pull/4645)) ### Metrics From 458c184fd1a63e3a1749db4fe77ec0b6fe7b17f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Paj=C4=85k?= Date: Tue, 23 Sep 2025 18:19:55 +0200 Subject: [PATCH 4/4] Update sdk.md --- specification/logs/sdk.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/logs/sdk.md b/specification/logs/sdk.md index 1fda0ebbf13..dee7ab2f935 100644 --- a/specification/logs/sdk.md +++ b/specification/logs/sdk.md @@ -193,7 +193,7 @@ It consists of the following parameters: If a `Logger` is disabled, it MUST behave equivalently to [No-op Logger](./noop.md#logger). - + * `minimum_severity`: A [SeverityNumber](./data-model.md#field-severitynumber) indicating the minimum severity level for log records to be processed.