Merge pull request #259 from danielqsj/init

Ignacio Bonafonte · web-flow · commit 05616aa63203 · 2021-10-27T17:23:13.000+02:00
Display correct serviceName for zipkin

Currently, ZipkinTraceExporter does not honor the serviceName which configured in ZipkinTraceExporterOptions.
It always set the serviceName as Open Telemetry Exporter.

This PR aims to fix it, then zipkin server can display the correct serviceName.
diff --git a/Sources/Exporters/Zipkin/ZipkinTraceExporter.swift b/Sources/Exporters/Zipkin/ZipkinTraceExporter.swift
@@ -12,7 +12,7 @@ public class ZipkinTraceExporter: SpanExporter {
 
     public init(options: ZipkinTraceExporterOptions) {
         self.options = options
-        localEndPoint = ZipkinTraceExporter.getLocalZipkinEndpoint(name: "Open Telemetry Exporter")
+        localEndPoint = ZipkinTraceExporter.getLocalZipkinEndpoint(name: options.serviceName)
     }
 
     public func export(spans: [SpanData]) -> SpanExporterResultCode {

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ public class ZipkinTraceExporter: SpanExporter {`
`12`	`12`
`13`	`13`	`public init(options: ZipkinTraceExporterOptions) {`
`14`	`14`	`self.options = options`
`15`		`- localEndPoint = ZipkinTraceExporter.getLocalZipkinEndpoint(name: "Open Telemetry Exporter")`
	`15`	`+ localEndPoint = ZipkinTraceExporter.getLocalZipkinEndpoint(name: options.serviceName)`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`public func export(spans: [SpanData]) -> SpanExporterResultCode {`