Skip to content

Commit 26095e3

Browse files
author
Ignacio Bonafonte
authored
Merge pull request #164 from nachoBonafonte/clarify-experimental-statuses
Add experimental information about the specs. We have added extra information to the readme and renamed some libraries only dependant on those experimental API. I hope it is enough to solve the issue.
2 parents d60fbab + 68dc08e commit 26095e3

20 files changed

+21
-13
lines changed

Package.swift

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,18 @@ let package = Package(
1414
.library(name: "libOpenTelemetryApi", type: .static, targets: ["OpenTelemetryApi"]),
1515
.library(name: "OpenTelemetrySdk", type: .dynamic, targets: ["OpenTelemetrySdk"]),
1616
.library(name: "libOpenTelemetrySdk", type: .static, targets: ["OpenTelemetrySdk"]),
17-
.library(name: "OpenTracingShim", type: .dynamic, targets: ["OpenTracingShim"]),
18-
.library(name: "libOpenTracingShim", type: .static, targets: ["OpenTracingShim"]),
19-
.library(name: "SwiftMetricsShim", type: .dynamic, targets: ["SwiftMetricsShim"]),
20-
.library(name: "libSwiftMetricsShim", type: .static, targets: ["SwiftMetricsShim"]),
17+
.library(name: "OpenTracingShim-experimental", type: .dynamic, targets: ["OpenTracingShim"]),
18+
.library(name: "libOpenTracingShim-experimental", type: .static, targets: ["OpenTracingShim"]),
19+
.library(name: "SwiftMetricsShim-experimental", type: .dynamic, targets: ["SwiftMetricsShim"]),
20+
.library(name: "libSwiftMetricsShim-experimental", type: .static, targets: ["SwiftMetricsShim"]),
2121
.library(name: "JaegerExporter", type: .dynamic, targets: ["JaegerExporter"]),
2222
.library(name: "libJaegerExporter", type: .static, targets: ["JaegerExporter"]),
2323
.library(name: "ZipkinExporter", type: .dynamic, targets: ["ZipkinExporter"]),
2424
.library(name: "libZipkinExporter", type: .static, targets: ["ZipkinExporter"]),
2525
.library(name: "StdoutExporter", type: .dynamic, targets: ["StdoutExporter"]),
2626
.library(name: "libStdoutExporter", type: .static, targets: ["StdoutExporter"]),
27-
.library(name: "PrometheusExporter", type: .dynamic, targets: ["PrometheusExporter"]),
28-
.library(name: "libPrometheusExporter", type: .static, targets: ["PrometheusExporter"]),
27+
.library(name: "PrometheusExporter-experimental", type: .dynamic, targets: ["PrometheusExporter"]),
28+
.library(name: "libPrometheusExporter-experimental", type: .static, targets: ["PrometheusExporter"]),
2929
.library(name: "OpenTelemetryProtocolExporter", type: .dynamic, targets: ["OpenTelemetryProtocolExporter"]),
3030
.library(name: "libOpenTelemetryProtocolExporter", type: .static, targets: ["OpenTelemetryProtocolExporter"]),
3131
.library(name: "InMemoryExporter", type: .dynamic, targets: ["InMemoryExporter"]),
@@ -53,12 +53,15 @@ let package = Package(
5353
),
5454
.target(name: "OpenTracingShim",
5555
dependencies: ["OpenTelemetrySdk",
56-
"Opentracing"]
56+
"Opentracing"],
57+
path: "Sources/Importers/OpenTracingShim"
5758
),
5859
.target(name: "SwiftMetricsShim",
5960
dependencies: ["OpenTelemetrySdk",
6061
.product(name: "NIO", package: "swift-nio"),
61-
.product(name: "CoreMetrics", package: "swift-metrics")]
62+
.product(name: "CoreMetrics", package: "swift-metrics")],
63+
path: "Sources/Importers/SwiftMetricsShim"
64+
6265
),
6366
.target(name: "JaegerExporter",
6467
dependencies: ["OpenTelemetrySdk",
@@ -100,12 +103,12 @@ let package = Package(
100103
.testTarget(name: "OpenTracingShimTests",
101104
dependencies: ["OpenTracingShim",
102105
"OpenTelemetrySdk"],
103-
path: "Tests/OpenTracingShim"
106+
path: "Tests/ImportersTests/OpenTracingShim"
104107
),
105108
.testTarget(name: "SwiftMetricsShimTests",
106109
dependencies: ["SwiftMetricsShim",
107110
"OpenTelemetrySdk"],
108-
path: "Tests/SwiftMetricsShim"
111+
path: "Tests/ImportersTests/SwiftMetricsShim"
109112
),
110113
.testTarget(name: "OpenTelemetrySdkTests",
111114
dependencies: ["OpenTelemetryApi",

README.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,14 @@ or
3232
```
3333

3434
## Current status
35-
**Please note** Tracing spec follows version 1.0.1 and should be considered almost stable now. Metrics support is experimental, and the spec is still under development
36-
37-
Currently Tracing, Metrics and Baggage API's and SDK are implemented, also OpenTracing shims, for compatibility with existing Opentracing code.
35+
<!--Please note:
36+
Tracing spec follows version 1.0.1 and should be considered almost stable now.
37+
Metrics support is experimental, and the spec is still under development.
38+
Semantic Conventions AND OpenTracing shim are also experimental.
39+
Libraries only dependant on these experimental status include the experimental postfix
40+
-->
41+
42+
Currently Tracing, Metrics and Baggage API's and SDK are implemented, also OpenTracing shim, for compatibility with existing Opentracing code.
3843

3944
Implemented traces exporters: Stdout, Jaeger, Zipkin, Datadog and OpenTelemetry collector
4045

0 commit comments

Comments
 (0)