Skip to content

Commit 42da6ae

Browse files
author
Ignacio Bonafonte
authored
Make TracerSdkProvider initializer public, and use default values for parameters so user only needs to change what is needed (#106)
1 parent b42d035 commit 42da6ae

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

Sources/OpenTelemetrySdk/Internal/MillisClock.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@
1616
import Foundation
1717
import OpenTelemetryApi
1818

19-
class MillisClock: Clock {
19+
public class MillisClock: Clock {
2020
/// Returns a MillisClock
21-
init() {}
21+
public init() {}
2222

23-
var now: Date {
23+
public var now: Date {
2424
return Date()
2525
}
2626
}

Sources/OpenTelemetrySdk/Trace/TracerSdkProvider.swift

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,9 @@ public class TracerSdkProvider: TracerProvider {
2222
private var sharedState: TracerSharedState
2323

2424
/// Returns a new TracerSdkProvider with default Clock, IdsGenerator and Resource.
25-
public convenience init() {
26-
self.init(clock: MillisClock(), idsGenerator: RandomIdsGenerator(), resource: EnvVarResource.resource)
27-
}
28-
29-
init(clock: Clock, idsGenerator: IdsGenerator, resource: Resource) {
25+
public init(clock: Clock = MillisClock(),
26+
idsGenerator: IdsGenerator = RandomIdsGenerator(),
27+
resource: Resource = EnvVarResource.resource) {
3028
sharedState = TracerSharedState(clock: clock, idsGenerator: idsGenerator, resource: resource)
3129
}
3230

0 commit comments

Comments
 (0)