Skip to content

Commit 50f4530

Browse files
author
Ignacio Bonafonte
authored
Merge pull request #180 from sodabrew/patch-1
Typo fix: ipv5 used for ipv6 in the ZipkinExporter
2 parents 9cd9431 + 712231f commit 50f4530

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Sources/Exporters/Zipkin/Implementation/ZipkinEndpoint.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,15 @@ class ZipkinEndpoint: Encodable {
2121
var ipv6: String?
2222
var port: Int?
2323

24-
public init(serviceName: String, ipv4: String? = nil, ipv5: String? = nil, port: Int? = nil) {
24+
public init(serviceName: String, ipv4: String? = nil, ipv6: String? = nil, port: Int? = nil) {
2525
self.serviceName = serviceName
2626
self.ipv4 = ipv4
27-
self.ipv6 = ipv5
27+
self.ipv6 = ipv6
2828
self.port = port
2929
}
3030

3131
public func clone(serviceName: String) -> ZipkinEndpoint {
32-
return ZipkinEndpoint(serviceName: serviceName, ipv4: ipv4, ipv5: ipv6, port: port)
32+
return ZipkinEndpoint(serviceName: serviceName, ipv4: ipv4, ipv6: ipv6, port: port)
3333
}
3434

3535
public func write() -> [String: Any] {

Sources/Exporters/Zipkin/ZipkinTraceExporter.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public class ZipkinTraceExporter: SpanExporter {
7676
#if os(OSX)
7777
let ipv4 = Host.current().addresses.filter{ NetworkUtils.isValidIpv4Address($0) }.sorted().first
7878
let ipv6 = Host.current().addresses.filter { NetworkUtils.isValidIpv6Address($0) }.sorted().first
79-
return ZipkinEndpoint(serviceName: hostname, ipv4: ipv4, ipv5: ipv6, port: nil)
79+
return ZipkinEndpoint(serviceName: hostname, ipv4: ipv4, ipv6: ipv6, port: nil)
8080
#else
8181
return ZipkinEndpoint(serviceName: hostname)
8282
#endif

0 commit comments

Comments
 (0)