Apply suggestions from @ncreated code review

Author: Ignacio Bonafonte

Sources/Exporters/DatadogExporter/ExporterConfiguration.swift

@@ -38,7 +38,7 @@ public struct ExporterConfiguration {
     /// Option to add a custom prefix to all the metrics sent by the exporter
     var metricsNamePrefix: String?
 
-    public init(serviceName: String, resource: String, applicationName: String, applicationVersion: String, environment: String, apiKey: String, endpoint: Endpoint, source: String = "otel-swift-exporter", uploadCondition: @escaping () -> Bool, performancePreset: PerformancePreset = .default, exportUnsampledSpans: Bool = true, exportUnsampledLogs: Bool = true, hostName: String? = nil, metricsNamePrefix: String? = "otel") {
+    public init(serviceName: String, resource: String, applicationName: String, applicationVersion: String, environment: String, apiKey: String, endpoint: Endpoint, source: String = "ios", uploadCondition: @escaping () -> Bool, performancePreset: PerformancePreset = .default, exportUnsampledSpans: Bool = true, exportUnsampledLogs: Bool = true, hostName: String? = nil, metricsNamePrefix: String? = "otel") {
         self.serviceName = serviceName
         self.resource = resource
         self.applicationName = applicationName

Sources/Exporters/DatadogExporter/Upload/DataUploadStatus.swift

@@ -3,7 +3,6 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-
 import Foundation
 
 private enum HTTPResponseStatusCode: Int {
@@ -52,35 +51,17 @@ internal struct DataUploadStatus {
     /// If set to `false` then data associated with the upload should be deleted as it does not need any more upload
     /// attempts (i.e. the upload succeeded or failed due to unrecoverable client error).
     let needsRetry: Bool
-
-    // MARK: - Debug Info
-
-    /// Upload status description printed to the console if SDK `.debug` verbosity is enabled.
-    let userDebugDescription: String
-
-    /// An optional error printed to the console if SDK `.error` (or lower) verbosity is enabled.
-    /// It is meant to indicate user action that must be taken to fix the upload issue (e.g. if the client token is invalid, it needs to be fixed).
-    let userErrorMessage: String?
 }
 
 extension DataUploadStatus {
     // MARK: - Initialization
 
     init(httpResponse: HTTPURLResponse, ddRequestID: String?) {
         let statusCode = HTTPResponseStatusCode(rawValue: httpResponse.statusCode) ?? .unexpected
-
-        self.init(
-            needsRetry: statusCode.needsRetry,
-            userDebugDescription: "[response code: \(httpResponse.statusCode) (\(statusCode)), request ID: \(ddRequestID ?? "(???)")]",
-            userErrorMessage: statusCode == .unauthorized ? "⚠️ The client token you provided seems to be invalid." : nil
-        )
+        self.init(needsRetry: statusCode.needsRetry)
     }
 
     init(networkError: Error) {
-        self.init(
-            needsRetry: true, // retry this upload as it failed due to network transport isse
-            userDebugDescription: "[error: \(networkError.localizedDescription)]", // e.g. "[error: A data connection is not currently allowed]"
-            userErrorMessage: nil // nothing actionable for the user
-        )
+        self.init(needsRetry: true)
     }
 }

Sources/Exporters/DatadogExporter/Upload/DataUploader.swift

@@ -14,7 +14,7 @@ internal protocol DataUploaderType {
 /// Synchronously uploads data to server using `HTTPClient`.
 internal final class DataUploader: DataUploaderType {
     /// An unreachable upload status - only meant to satisfy the compiler.
-    private static let unreachableUploadStatus = DataUploadStatus(needsRetry: false, userDebugDescription: "", userErrorMessage: nil)
+    private static let unreachableUploadStatus = DataUploadStatus(needsRetry: false)
 
     private let httpClient: HTTPClient
     private let requestBuilder: RequestBuilder

Sources/Exporters/DatadogExporter/Upload/RequestBuilder.swift

@@ -130,7 +130,7 @@ internal struct RequestBuilder {
 
     /// Creates `URLRequest` for uploading given `data` to Datadog.
     /// - Parameter data: data to be uploaded
-    /// - Returns: the `URLRequest` object and `DD-REQUEST-ID` header value (for debugging).
+    /// - Returns: the `URLRequest` object.
     func uploadRequest(with data: Data) -> URLRequest {
         var request = URLRequest(url: url)
         var headers = precomputedHeaders

Tests/ExportersTests/DatadogExporter/Helpers/CoreMocks.swift

@@ -163,24 +163,13 @@ struct DataUploaderMock: DataUploaderType {
 extension DataUploadStatus: RandomMockable {
     static func mockRandom() -> DataUploadStatus {
         let retryRandom: Bool = .random()
-        return DataUploadStatus(
-            needsRetry: retryRandom,
-            userDebugDescription: .mockRandom(),
-            userErrorMessage: .mockRandom()
-        )
+        return DataUploadStatus(needsRetry: retryRandom)
     }
 
     static func mockWith(
         needsRetry: Bool = .mockAny(),
-        accepted: Bool = true,
-        userDebugDescription: String = .mockAny(),
-        userErrorMessage: String? = nil,
-        internalMonitoringError: (message: String, error: Error?, attributes: [String: String]?)? = nil
+        accepted: Bool = true
     ) -> DataUploadStatus {
-        return DataUploadStatus(
-            needsRetry: needsRetry,
-            userDebugDescription: userDebugDescription,
-            userErrorMessage: userErrorMessage
-        )
+        return DataUploadStatus(needsRetry: needsRetry)
     }
 }