Merge pull request #406 from open-telemetry/remove-service-namespace

Ignacio Bonafonte · web-flow · commit a7004d0b13dd · 2023-04-25T09:56:05.000+02:00
Remove mis-use of service.namespace fixes #350
diff --git a/Sources/Instrumentation/SDKResourceExtension/ApplicationResourceProvider.swift b/Sources/Instrumentation/SDKResourceExtension/ApplicationResourceProvider.swift
@@ -25,10 +25,6 @@ public class ApplicationResourceProvider: ResourceProvider {
             attributes[ResourceAttributes.serviceVersion.rawValue] = AttributeValue.string(version)
         }
 
-        if let bundleId = applicationDataSource.identifier {
-            attributes[ResourceAttributes.serviceNamespace.rawValue] = AttributeValue.string(bundleId)
-        }
-
         return attributes
     }
 

Original file line number	Diff line number	Diff line change
`@@ -25,10 +25,6 @@ public class ApplicationResourceProvider: ResourceProvider {`
`25`	`25`	`attributes[ResourceAttributes.serviceVersion.rawValue] = AttributeValue.string(version)`
`26`	`26`	`}`
`27`	`27`
`28`		`- if let bundleId = applicationDataSource.identifier {`
`29`		`- attributes[ResourceAttributes.serviceNamespace.rawValue] = AttributeValue.string(bundleId)`
`30`		`- }`
`31`		`-`
`32`	`28`	`return attributes`
`33`	`29`	`}`
`34`	`30`