Skip to content

Commit bf5f4ec

Browse files
committed
fixed tests
1 parent a1e64a1 commit bf5f4ec

File tree

2 files changed

+14
-23
lines changed

2 files changed

+14
-23
lines changed

Tests/ExportersTests/OpenTelemetryProtocol/OtlpLogRecordExporterTests.swift

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -86,16 +86,12 @@ class OtlpLogRecordExporterTests: XCTestCase {
8686

8787
func testImplicitGrpcLoggingConfig() throws {
8888
let exporter = OtlpLogExporter(channel: channel)
89-
guard let logger = exporter.callOptions?.logger else {
90-
throw "Missing logger"
91-
}
89+
let logger = exporter.callOptions.logger
9290
XCTAssertEqual(logger.label, "io.grpc")
9391
}
9492
func testExplicitGrpcLoggingConfig() throws {
9593
let exporter = OtlpLogExporter(channel: channel, logger: Logger(label: "my.grpc.logger"))
96-
guard let logger = exporter.callOptions?.logger else {
97-
throw "Missing logger"
98-
}
94+
let logger = exporter.callOptions.logger
9995
XCTAssertEqual(logger.label, "my.grpc.logger")
10096
}
10197

@@ -110,13 +106,13 @@ class OtlpLogRecordExporterTests: XCTestCase {
110106
XCTAssertNotNil(exporter.config.headers)
111107
XCTAssertEqual(exporter.config.headers?[0].0, "FOO")
112108
XCTAssertEqual(exporter.config.headers?[0].1, "BAR")
113-
XCTAssertEqual("BAR", exporter.callOptions?.customMetadata.first(name: "FOO"))
109+
XCTAssertEqual("BAR", exporter.callOptions.customMetadata.first(name: "FOO"))
114110
}
115111

116112
func testConfigHeadersAreSet_whenInitCalledWithExplicitHeaders() throws {
117113
let exporter = OtlpLogExporter(channel: channel, envVarHeaders: [("FOO", "BAR")])
118114
XCTAssertNil(exporter.config.headers)
119-
XCTAssertEqual("BAR", exporter.callOptions?.customMetadata.first(name: "FOO"))
115+
XCTAssertEqual("BAR", exporter.callOptions.customMetadata.first(name: "FOO"))
120116
}
121117

122118
func testExportAfterShutdown() {

Tests/ExportersTests/OpenTelemetryProtocol/OtlpTraceExporterTests.swift

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -50,28 +50,23 @@ class OtlpTraceExporterTests: XCTestCase {
5050

5151
func testImplicitGrpcLoggingConfig() throws {
5252
let exporter = OtlpTraceExporter(channel: channel)
53-
guard let logger = exporter.callOptions?.logger else {
54-
throw "Missing logger"
55-
}
56-
XCTAssertEqual(logger.label, "io.grpc")
53+
let logger = exporter.callOptions.logger
5754
}
5855

5956
func testExplicitGrpcLoggingConfig() throws {
6057
let exporter = OtlpTraceExporter(channel: channel, logger: Logger(label: "my.grpc.logger"))
61-
guard let logger = exporter.callOptions?.logger else {
62-
throw "Missing logger"
63-
}
58+
let logger = exporter.callOptions.logger
6459
XCTAssertEqual(logger.label, "my.grpc.logger")
6560
}
6661

6762
func verifyUserAgentIsSet(exporter: OtlpTraceExporter) {
68-
if let callOptions = exporter.callOptions {
69-
let customMetadata = callOptions.customMetadata
70-
let userAgent = Headers.getUserAgentHeader()
71-
if customMetadata.contains(name: Constants.HTTP.userAgent) && customMetadata.first(name: Constants.HTTP.userAgent) == userAgent {
72-
return
73-
}
63+
let callOptions = exporter.callOptions
64+
let customMetadata = callOptions.customMetadata
65+
let userAgent = Headers.getUserAgentHeader()
66+
if customMetadata.contains(name: Constants.HTTP.userAgent) && customMetadata.first(name: Constants.HTTP.userAgent) == userAgent {
67+
return
7468
}
69+
7570
XCTFail("User-Agent header was not set correctly")
7671
}
7772

@@ -88,15 +83,15 @@ class OtlpTraceExporterTests: XCTestCase {
8883
XCTAssertNotNil(exporter.config.headers)
8984
XCTAssertEqual(exporter.config.headers?[0].0, "FOO")
9085
XCTAssertEqual(exporter.config.headers?[0].1, "BAR")
91-
XCTAssertEqual("BAR", exporter.callOptions?.customMetadata.first(name: "FOO"))
86+
XCTAssertEqual("BAR", exporter.callOptions.customMetadata.first(name: "FOO"))
9287

9388
verifyUserAgentIsSet(exporter: exporter)
9489
}
9590

9691
func testConfigHeadersAreSet_whenInitCalledWithExplicitHeaders() throws {
9792
let exporter = OtlpTraceExporter(channel: channel, envVarHeaders: [("FOO", "BAR")])
9893
XCTAssertNil(exporter.config.headers)
99-
XCTAssertEqual("BAR", exporter.callOptions?.customMetadata.first(name: "FOO"))
94+
XCTAssertEqual("BAR", exporter.callOptions.customMetadata.first(name: "FOO"))
10095

10196
verifyUserAgentIsSet(exporter: exporter)
10297
}

0 commit comments

Comments
 (0)