Use ResourceValue enum

Author: BennettSmith

Tests/OpenTelemetrySdkTests/Resource/EnvVarResourceTest.swift

@@ -11,34 +11,41 @@ class EnvVarResourceTest: XCTestCase {
     func testDefaultSharedInstance() {
         let resource = EnvVarResource.resource
         XCTAssertEqual(resource.attributes.count, 4)
-        XCTAssertTrue(resource.attributes.keys.contains("service.name"))
-        XCTAssertTrue(resource.attributes.keys.contains("telemetry.sdk.name"))
-        XCTAssertTrue(resource.attributes.keys.contains("telemetry.sdk.language"))
-        XCTAssertTrue(resource.attributes.keys.contains("telemetry.sdk.version"))
+        XCTAssertTrue(resource.attributes.keys.contains(ResourceAttributes.serviceName.rawValue))
+        XCTAssertTrue(resource.attributes.keys.contains(ResourceAttributes.telemetrySdkName.rawValue))
+        XCTAssertTrue(resource.attributes.keys.contains(ResourceAttributes.telemetrySdkLanguage.rawValue))
+        XCTAssertTrue(resource.attributes.keys.contains(ResourceAttributes.telemetrySdkVersion.rawValue))
     }
 
     func testGetUniqueInstance() {
         let resource = EnvVarResource.get()
         XCTAssertEqual(resource.attributes.count, 4)
-        XCTAssertTrue(resource.attributes.keys.contains("service.name"))
-        XCTAssertTrue(resource.attributes.keys.contains("telemetry.sdk.name"))
-        XCTAssertTrue(resource.attributes.keys.contains("telemetry.sdk.language"))
-        XCTAssertTrue(resource.attributes.keys.contains("telemetry.sdk.version"))
+        XCTAssertTrue(resource.attributes.keys.contains(ResourceAttributes.serviceName.rawValue))
+        XCTAssertTrue(resource.attributes.keys.contains(ResourceAttributes.telemetrySdkName.rawValue))
+        XCTAssertTrue(resource.attributes.keys.contains(ResourceAttributes.telemetrySdkLanguage.rawValue))
+        XCTAssertTrue(resource.attributes.keys.contains(ResourceAttributes.telemetrySdkVersion.rawValue))
     }
 
     func testGetUniqueInstanceConsideringEnvironment() {
         let environment = [ "OTEL_RESOURCE_ATTRIBUTES": "unique.key=some.value,another.key=another.value"]
         let resource = EnvVarResource.get(environment: environment)
         XCTAssertEqual(resource.attributes.count, 6)
-        XCTAssertTrue(resource.attributes.keys.contains("service.name"))
-        XCTAssertTrue(resource.attributes.keys.contains("telemetry.sdk.name"))
-        XCTAssertTrue(resource.attributes.keys.contains("telemetry.sdk.language"))
-        XCTAssertTrue(resource.attributes.keys.contains("telemetry.sdk.version"))
+        XCTAssertTrue(resource.attributes.keys.contains(ResourceAttributes.serviceName.rawValue))
+        XCTAssertTrue(resource.attributes.keys.contains(ResourceAttributes.telemetrySdkName.rawValue))
+        XCTAssertTrue(resource.attributes.keys.contains(ResourceAttributes.telemetrySdkLanguage.rawValue))
+        XCTAssertTrue(resource.attributes.keys.contains(ResourceAttributes.telemetrySdkVersion.rawValue))
 
         XCTAssertTrue(resource.attributes.keys.contains("unique.key"))
         XCTAssertEqual(resource.attributes["unique.key"]!, AttributeValue("some.value"))
 
         XCTAssertTrue(resource.attributes.keys.contains("another.key"))
         XCTAssertEqual(resource.attributes["another.key"]!, AttributeValue("another.value"))
     }
+
+    func testSpecifyingServiceNameViaEnvironment_changesResourceAttributeValue() {
+        let environment = [ "OTEL_RESOURCE_ATTRIBUTES": "service.name=CustomServiceName"]
+        let resource = EnvVarResource.get(environment: environment)
+        XCTAssertTrue(resource.attributes.keys.contains(ResourceAttributes.serviceName.rawValue))
+        XCTAssertEqual(resource.attributes[ResourceAttributes.serviceName.rawValue], AttributeValue("CustomServiceName"))
+    }
 }