Merge branch 'main' into Save-spec-version-in-the-library

Author: Ignacio Bonafonte

README.md

@@ -39,20 +39,20 @@ or
 Official documentation for the library can be found in the official opentelemetry [documentation  page](https://opentelemetry.io/docs/instrumentation/swift/), including:
 
  * Documentation about installation and [manual instrumentation](https://opentelemetry.io/docs/instrumentation/swift/manual/)
-    
+   
 * [Libraries](https://opentelemetry.io/docs/instrumentation/swift/libraries/) that provide automatic instrumentation
 
 ## Current status
 
 ### API and SDK
 
-Tracing and Baggage should be considered stable
+Tracing and Baggage are considered stable
 
-Metrics is implemented using an outdated spec, is fully functional but will change in the future
+Logs are considered beta quality
 
-Logs are currently in development
+Metrics is implemented using an outdated spec, is fully functional but will change in the future
 
-### Supported exporters, importers and instrumentation libraries
+### Supported exporters and importers
 
 #### Traces
 * Exporters: Stdout, Jaeger, Zipkin, Datadog and OpenTelemetry (OTLP) collector
@@ -62,7 +62,12 @@ Logs are currently in development
 * Exporters: Prometheus, Datadog, and OpenTelemetry (OTLP) collector
 * Importers: SwiftMetricsShim
 
-#### Instrumentation libraries
+#### Logs 
+* Exporters: OpenTelemetry (OTLP) collector
+
+> **_NOTE:_** OTLP exporters are supported both in GRPC and HTTP/JSON, only GRPC is production ready, HTTP/JSON is still experimental
+
+### Instrumentation libraries
 * URLSession
 * NetworkStatus
 * SDKResourceExtension
@@ -79,5 +84,3 @@ The package includes some example projects with basic functionality:
 - `Simple Exporter` - Shows the Jaeger an Stdout exporters in action using a MultiSpanExporter. Can be easily modified for other exporters
 - `Prometheus Sample` - Shows the Prometheus exporter reporting metrics to a Prometheus instance
 - `OTLP Exporter` - Shows the OTLP exporter reporting traces to Zipkin and metrics to a Prometheus via the otel-collector
-
-

Sources/OpenTelemetrySdk/Trace/AttributesDictionary.swift

@@ -29,7 +29,7 @@ public struct AttributesDictionary {
         }
         set {
             if newValue == nil {
-                removeValueForKey(key: key)
+                _ = removeValueForKey(key: key)
             } else {
                 _ = updateValue(value: newValue!, forKey: key)
             }
@@ -81,11 +81,11 @@ public struct AttributesDictionary {
         }
     }
 
-    public mutating func removeValueForKey(key: String) {
+    public mutating func removeValueForKey(key: String) -> AttributeValue? {
         keys = keys.filter {
             $0 != key
         }
-        attributes.removeValue(forKey: key)
+        return attributes.removeValue(forKey: key)
     }
 
     public mutating func removeAll(keepCapacity: Int) {

Sources/OpenTelemetrySdk/Trace/RecordEventsReadableSpan.swift

@@ -242,7 +242,10 @@ public class RecordEventsReadableSpan: ReadableSpan {
             }
 
             if value == nil {
-                attributes.removeValueForKey(key: key)
+                if attributes.removeValueForKey(key: key) != nil {
+                    totalAttributeCount -= 1
+                }
+                return
             }
             totalAttributeCount += 1
             if attributes[key] == nil, totalAttributeCount > maxNumberOfAttributes {

Tests/OpenTelemetrySdkTests/Trace/RecordEventsReadableSpanTests.swift

@@ -235,14 +235,24 @@ class RecordEventsReadableSpanTest: XCTestCase {
         let spanData = span.toSpanData()
         XCTAssertEqual(spanData.events.count, 2)
     }
-    
+
     func testWithInitializedAttributes() {
-        
-        let attributes =  ["hello" : AttributeValue.string("world")]
-        
+        let attributes = ["hello": AttributeValue.string("world")]
+
         let span = createTestSpan(attributes: attributes)
-        
+
         XCTAssertEqual(attributes.count, span.totalAttributeCount, "total attributes not counted properly")
+        XCTAssertEqual(span.toSpanData().attributes.count, span.totalAttributeCount, "total attributes not counted properly")
+
+    }
+
+    func testRemovingAttributes() {
+        let attributes = ["remove": AttributeValue.string("me")]
+        let span = createTestSpan(attributes: attributes)
+        span.setAttribute(key: "keep", value: "me")
+        span.setAttribute(key: "remove", value: nil)
+        XCTAssertEqual(1, span.totalAttributeCount, "total attributes not counted properly")
+        XCTAssertEqual(span.toSpanData().attributes.count, span.totalAttributeCount, "total attributes not counted properly")
     }
 
     func testDroppingAttributes() {