Skip to content

Verify AlamoFire instrumentation #941

@bryce-b

Description

@bryce-b

related issue: #913

Summary

The NSURLSession instrumentation attempts to capture network traffic of AFNetworking through the detection of AFURLSessionManager and instrumentation of the af_resume method. However, it does not verify the class attached to that method, which means this may be overriding any method with this name regardless of whether is it related to AFNetworking. AFNetworking was replaced by AlamoFire in 2020, so it may be the case that we should remove this instrumentation completely.

Todo

  • Is there a af_resume method not related to AFNetworking being swizzled by this code?
    • Since AFNetworking is deprecated we ought to remove this instrumentation regardless of the outcome of the above question.
  • Is AlamoFire compatible with our instrumentation (e.g.: can we capture network data)
    • Should we add an integration test for this? (let's create another ticket if that's the case)
    • If we do not support AlamoFire, what needs to get done to support it? e.g.: minor documentation, or additional instrumentation? (separate module?) Additional feature issues should be created, if this is the case.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions