-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: update sample commands in content/en/docs/contributing/blog.md #8496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: update sample commands in content/en/docs/contributing/blog.md #8496
Conversation
9e7e359 to
9015cee
Compare
theletterf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Perhaps we could change the year in that command with {{ time.Now.Year }} — WDYT @chalin ?
chalin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luke6Lh43, thanks for point this out!
Thanks! Perhaps we could change the year in that command with {{ time.Now.Year }} — WDYT @chalin ?
Right, I'd prefer that, but it's a bit tricky without a shortcode. Let me think about this.
chalin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luke6Lh43 - please revert the changes to the prose, and replace:
- 2024 by
$(date +%Y)in the two shell commands - See inline comment for the other suggestion
9015cee to
28dff3c
Compare
|
Hi @chalin . I have updated content/en/docs/contributing/blog.md with your recommendations. However, I don't see $(date +%Y) to be working correctly in both VS Code Markdown preview and when reviewing file on Github. Do I understand it correctly that it is something Hugo specific that will work on a website once published? |
|
@luke6Lh43 @chalin That's right, it doesn't seem to work in the preview: |
|
I'd say the I tried running the command below, and the page was correctly created under |
|
@vitorvasc 🤦🏻 You're right. I think we can go ahead then. :) |
45f32e7 to
7198412
Compare
|
Thanks. I'll let @vitorvasc and @theletterf handle it from here (I'll be OOO). |
7198412 to
a5a773a
Compare
vitorvasc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @luke6Lh43!
|
@theletterf leaving it with you for a final review and merge! :) |
Hi all,
I’d like to propose this small change in Docs/Contributing/Blog after encountering some issues while creating my recent blog post. I blindly copied and pasted the sample commands, which still referenced the year 2024, resulting in my new blog post being created in the wrong directory. I then had to fix this in my local repository and move it to 2025.
To help prevent this for others, I have:
Updated the sample commands to use 2025 in the path
Added comments in brackets reminding users to check the path and year
Ideally, it would be great to have automation that updates sample commands across the docs each year on January 1st :)
Thank you for considering this improvement!