Skip to content

Improve shared channel error handling #1703

@lquerel

Description

@lquerel

In rust/otap-dataflow/crates/engine/src/shared/message.rs (line 292)

It seems we are mapping all errors to RecvError::Closed. Better to check for TryRecvError::Empty and TryRecvError::Disconnected (for both tokio::x::mpsc and flume) and handle accordingly.

See: #1697 (comment)

Metadata

Metadata

Assignees

Labels

debuggabilityTraceability, dump, verbose modeobservabilityEngine observability

Type

Projects

Status

No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions