Skip to content

Commit ede8688

Browse files
authored
Exclude namespaces that aren't useful in jvm environments (#54)
* Exclude namespaces that aren't useful in jvm environments * Fix test
1 parent 97bf96c commit ede8688

File tree

4 files changed

+4
-67
lines changed

4 files changed

+4
-67
lines changed

build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,8 @@ fun generateTask(taskName: String, incubating: Boolean) {
9898
"--template", "/templates/SemanticAttributes.java.j2",
9999
"--output", "/output/{{pascal_prefix}}${classPrefix}Attributes.java",
100100
"--file-per-group", "root_namespace",
101+
// Space delimited list of root namespaces to excluded (i.e. "foo bar")
102+
"-Dexcluded_namespaces=\"ios\"",
101103
"-Dfilter=${filter}",
102104
"-DclassPrefix=${classPrefix}",
103105
"-Dpkg=$packageNameArg",

buildscripts/templates/SemanticAttributes.java.j2

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@
3737
{%- set filtered_attributes = attributes_and_templates | list %}
3838
{%- endif %}
3939
{%- set filtered_enums = filtered_attributes | selectattr('is_enum', 'equalto', true) | list %}
40-
{%- if filtered_attributes | count > 0 %}
40+
{%- set excluded_namespaces_list = excluded_namespaces.replace("\"", "").split(' ') %}
41+
{%- if root_namespace not in excluded_namespaces_list and filtered_attributes | count > 0 %}
4142
/*
4243
* Copyright The OpenTelemetry Authors
4344
* SPDX-License-Identifier: Apache-2.0

semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/IosIncubatingAttributes.java

Lines changed: 0 additions & 65 deletions
This file was deleted.

semconv-incubating/src/test/java/io/opentelemetry/semconv/incubating/IncubatingAvailabilityTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ void available() {
3636
isValidClass("io.opentelemetry.semconv.incubating.HerokuIncubatingAttributes");
3737
isValidClass("io.opentelemetry.semconv.incubating.HostIncubatingAttributes");
3838
isValidClass("io.opentelemetry.semconv.incubating.HttpIncubatingAttributes");
39-
isValidClass("io.opentelemetry.semconv.incubating.IosIncubatingAttributes");
4039
isValidClass("io.opentelemetry.semconv.incubating.JvmIncubatingAttributes");
4140
isValidClass("io.opentelemetry.semconv.incubating.K8sIncubatingAttributes");
4241
isValidClass("io.opentelemetry.semconv.incubating.LogIncubatingAttributes");

0 commit comments

Comments
 (0)