Skip to content

Conversation

@cboudereau
Copy link
Contributor

fixes #69

@cboudereau cboudereau requested a review from a team September 17, 2024 16:18
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 17, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@cboudereau cboudereau marked this pull request as draft September 19, 2024 14:40
@cboudereau cboudereau marked this pull request as ready for review September 23, 2024 09:26
@cboudereau cboudereau requested a review from a team as a code owner September 23, 2024 09:26
@cboudereau
Copy link
Contributor Author

Hi,

I think the PR is done.

I used @see instead of @link since the moved classes are in another jar which is not referenced.

@cboudereau
Copy link
Contributor Author

cboudereau commented Sep 24, 2024

Hi @trask , it should be ok but the markdown link check failed because all "maven-badges.herokuapp.com" badges are down.

This is a problem related to maven-badges.herokuapp.com itself though.

@cboudereau
Copy link
Contributor Author

Hi @trask, I updated the PR to merge the recent changes from #83. It should be ok 👍

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@cboudereau
Copy link
Contributor Author

thanks!

I am not authorized to merge though.

@trask
Copy link
Member

trask commented Sep 26, 2024

it will need to be merged by one of the @open-telemetry/java-maintainers

@jack-berg
Copy link
Member

Sorry about the delay. Thanks!

@jack-berg jack-berg merged commit e1254cf into open-telemetry:main Oct 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decorate deprecations with suggested replacements

3 participants