Skip to content

Commit 1f5ad6b

Browse files
authored
pprof: add pprof.profile.comment (#2861)
Signed-off-by: Florian Lehner <[email protected]>
1 parent d1ad914 commit 1f5ad6b

File tree

5 files changed

+35
-0
lines changed

5 files changed

+35
-0
lines changed

.chloggen/pprof-comments.yaml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# Use this changelog template to create an entry for release notes.
2+
#
3+
# If your change doesn't affect end users you should instead start
4+
# your pull request title with [chore] or use the "Skip Changelog" label.
5+
6+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
7+
change_type: 'enhancement'
8+
9+
# The name of the area of concern in the attributes-registry, (e.g. http, cloud, db)
10+
component: pprof
11+
12+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
13+
note: add attribute pprof.profile.comment.
14+
15+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
16+
# The values here must be integers.
17+
issues: [2861]
18+
19+
# (Optional) One or more lines of additional information to render under the primary note.
20+
# These lines will be padded with 2 spaces and then inserted directly into the document.
21+
# Use pipe (|) for multiline entries.
22+
subtext:

docs/general/profiles.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ They may be used in any Profiles record they apply to.
8181
| [`pprof.mapping.has_functions`](/docs/registry/attributes/pprof.md) | boolean | Indicates that there are functions related to this mapping. | | `Recommended` | ![Development](https://img.shields.io/badge/-development-blue) |
8282
| [`pprof.mapping.has_inline_frames`](/docs/registry/attributes/pprof.md) | boolean | Indicates that there are inline frames related to this mapping. | | `Recommended` | ![Development](https://img.shields.io/badge/-development-blue) |
8383
| [`pprof.mapping.has_line_numbers`](/docs/registry/attributes/pprof.md) | boolean | Indicates that there are line numbers related to this mapping. | | `Recommended` | ![Development](https://img.shields.io/badge/-development-blue) |
84+
| [`pprof.profile.comment`](/docs/registry/attributes/pprof.md) | string[] | Free-form text associated with the profile. This field should not be used to store any machine-readable information, it is only for human-friendly content. | `["hello world", "bazinga"]` | `Recommended` | ![Development](https://img.shields.io/badge/-development-blue) |
8485

8586
<!-- markdownlint-restore -->
8687
<!-- prettier-ignore-end -->

docs/registry/attributes/pprof.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,4 @@ Attributes specific to pprof that help convert from pprof to Profiling signal.
1414
| <a id="pprof-mapping-has-functions" href="#pprof-mapping-has-functions">`pprof.mapping.has_functions`</a> | boolean | Indicates that there are functions related to this mapping. | | ![Development](https://img.shields.io/badge/-development-blue) |
1515
| <a id="pprof-mapping-has-inline-frames" href="#pprof-mapping-has-inline-frames">`pprof.mapping.has_inline_frames`</a> | boolean | Indicates that there are inline frames related to this mapping. | | ![Development](https://img.shields.io/badge/-development-blue) |
1616
| <a id="pprof-mapping-has-line-numbers" href="#pprof-mapping-has-line-numbers">`pprof.mapping.has_line_numbers`</a> | boolean | Indicates that there are line numbers related to this mapping. | | ![Development](https://img.shields.io/badge/-development-blue) |
17+
| <a id="pprof-profile-comment" href="#pprof-profile-comment">`pprof.profile.comment`</a> | string[] | Free-form text associated with the profile. This field should not be used to store any machine-readable information, it is only for human-friendly content. | `["hello world", "bazinga"]` | ![Development](https://img.shields.io/badge/-development-blue) |

model/pprof/common.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,5 @@ groups:
1515
requirement_level: recommended
1616
- ref: pprof.location.is_folded
1717
requirement_level: recommended
18+
- ref: pprof.profile.comment
19+
requirement_level: recommended

model/pprof/registry.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,3 +35,12 @@ groups:
3535
profile changes.
3636
stability: development
3737
type: boolean
38+
- id: pprof.profile.comment
39+
brief: >
40+
Free-form text associated with the profile. This field should not be
41+
used to store any machine-readable information, it is only for
42+
human-friendly content.
43+
type: string[]
44+
examples:
45+
- ["hello world", "bazinga"]
46+
stability: development

0 commit comments

Comments
 (0)