Skip to content

Commit 21b415d

Browse files
committed
Address unresolved review comments
- Simplify wording about append/prepend to avoid confusion - Clarify distinction between missing propagator vs empty context
1 parent af9e746 commit 21b415d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

docs/database/database-spans.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -488,11 +488,11 @@ relatively short and its cardinality remains low comparing to the `db.query.text
488488
489489
Instrumentations MAY propagate context using [SQL commenter](https://google.github.io/sqlcommenter/spec/) by injecting comments into SQL queries before execution. SQL commenter-based context propagation SHOULD NOT be enabled by default, but instrumentation MAY allow users to opt into it.
490490
491-
The instrumentation implementation SHOULD **append** the comment to the end of the query. Semantic conventions for individual database systems MAY specify different format depending on the specific database system's requirements or preferences. For instance, the instrumentation MAY **prepend** the comment at the beginning of the query.
491+
The instrumentation implementation SHOULD **append** the comment to the end of the query. Semantic conventions for individual database systems MAY specify different format, which may include different position, encoding, or schema, depending on the specific database system's requirements or preferences.
492492

493-
The instrumentation SHOULD allow users to pass a propagator to overwrite the global propagator.
493+
The instrumentation SHOULD allow users to pass a propagator to overwrite the global propagator. If no propagator is provided by the user, instrumentation SHOULD use the global propagator.
494494

495-
If the propagator does not provide any value, the instrumentation SHOULD NOT inject any comment into the query.
495+
If the propagator produces no output (empty context), the instrumentation SHOULD NOT inject an empty comment into the query.
496496

497497
**Examples:**
498498

0 commit comments

Comments
 (0)