Add metric value type everywhere (as code-generation annotation) (#2444)

Author: Liudmila Molkova

.chloggen/2444.yaml

@@ -0,0 +1,4 @@
+change_type: enhancement
+component: all
+note: Add `metric_value_type` code-generation annotation to all metric definitions.
+issues: [2444, 591]

model/aspnetcore/metrics.yaml

@@ -11,6 +11,9 @@ groups:
   - id: metric.aspnetcore.routing.match_attempts
     type: metric
     metric_name: aspnetcore.routing.match_attempts
+    annotations:
+      code_generation:
+        metric_value_type: int
     stability: stable
     brief: Number of requests that were attempted to be matched to an endpoint.
     instrument: counter
@@ -31,6 +34,9 @@ groups:
   - id: metric.aspnetcore.diagnostics.exceptions
     type: metric
     metric_name: aspnetcore.diagnostics.exceptions
+    annotations:
+      code_generation:
+        metric_value_type: int
     stability: stable
     brief: Number of exceptions caught by exception handling middleware.
     instrument: counter
@@ -52,6 +58,9 @@ groups:
   - id: metric.aspnetcore.rate_limiting.active_request_leases
     type: metric
     metric_name: aspnetcore.rate_limiting.active_request_leases
+    annotations:
+      code_generation:
+        metric_value_type: int
     stability: stable
     brief: Number of requests that are currently active on the server that hold a rate limiting lease.
     instrument: updowncounter
@@ -63,6 +72,9 @@ groups:
   - id: metric.aspnetcore.rate_limiting.request_lease.duration
     type: metric
     metric_name: aspnetcore.rate_limiting.request_lease.duration
+    annotations:
+      code_generation:
+        metric_value_type: double
     stability: stable
     brief: The duration of rate limiting lease held by requests on the server.
     instrument: histogram
@@ -74,6 +86,9 @@ groups:
   - id: metric.aspnetcore.rate_limiting.request.time_in_queue
     type: metric
     metric_name: aspnetcore.rate_limiting.request.time_in_queue
+    annotations:
+      code_generation:
+        metric_value_type: double
     stability: stable
     brief: The time the request spent in a queue waiting to acquire a rate limiting lease.
     instrument: histogram
@@ -88,6 +103,9 @@ groups:
   - id: metric.aspnetcore.rate_limiting.queued_requests
     type: metric
     metric_name: aspnetcore.rate_limiting.queued_requests
+    annotations:
+      code_generation:
+        metric_value_type: int
     stability: stable
     brief: Number of requests that are currently queued, waiting to acquire a rate limiting lease.
     instrument: updowncounter
@@ -99,6 +117,9 @@ groups:
   - id: metric.aspnetcore.rate_limiting.requests
     type: metric
     metric_name: aspnetcore.rate_limiting.requests
+    annotations:
+      code_generation:
+        metric_value_type: int
     stability: stable
     brief: Number of requests that tried to acquire a rate limiting lease.
     instrument: counter

model/azure/cosmosdb-metrics.yaml

@@ -2,6 +2,9 @@ groups:
   - id: metric.azure.cosmosdb.client.operation.request_charge
     type: metric
     metric_name: azure.cosmosdb.client.operation.request_charge
+    annotations:
+      code_generation:
+        metric_value_type: double
     brief: "[Request units](https://learn.microsoft.com/azure/cosmos-db/request-units) consumed by the operation"
     instrument: histogram
     unit: "{request_unit}"
@@ -20,6 +23,9 @@ groups:
   - id: metric.azure.cosmosdb.client.active_instance.count
     type: metric
     metric_name: azure.cosmosdb.client.active_instance.count
+    annotations:
+      code_generation:
+        metric_value_type: int
     brief: "Number of active client instances"
     instrument: updowncounter
     unit: "{instance}"

model/cicd/metrics.yaml

@@ -2,6 +2,9 @@ groups:
   - id: metric.cicd.pipeline.run.duration
     type: metric
     metric_name: cicd.pipeline.run.duration
+    annotations:
+      code_generation:
+        metric_value_type: double
     brief: 'Duration of a pipeline run grouped by pipeline, state and result.'
     instrument: histogram
     unit: "s"
@@ -22,6 +25,9 @@ groups:
   - id: metric.cicd.pipeline.run.active
     type: metric
     metric_name: cicd.pipeline.run.active
+    annotations:
+      code_generation:
+        metric_value_type: int
     brief: 'The number of pipeline runs currently active in the system by state.'
     instrument: updowncounter
     unit: "{run}"
@@ -36,6 +42,9 @@ groups:
   - id: metric.cicd.worker.count
     type: metric
     metric_name: cicd.worker.count
+    annotations:
+      code_generation:
+        metric_value_type: int
     brief: 'The number of workers on the CICD system by state.'
     instrument: updowncounter
     unit: "{count}"
@@ -46,6 +55,9 @@ groups:
   - id: metric.cicd.pipeline.run.errors
     type: metric
     metric_name: cicd.pipeline.run.errors
+    annotations:
+      code_generation:
+        metric_value_type: int
     brief: 'The number of errors encountered in pipeline runs (eg. compile, test failures).'
     note: |
       There might be errors in a pipeline run that are non fatal (eg. they are suppressed) or in a parallel stage multiple stages could have a fatal error.
@@ -63,6 +75,9 @@ groups:
   - id: metric.cicd.system.errors
     type: metric
     metric_name: cicd.system.errors
+    annotations:
+      code_generation:
+        metric_value_type: int
     brief: 'The number of errors in a component of the CICD system (eg. controller, scheduler, agent).'
     note: 'Errors in pipeline run execution are explicitly excluded. Ie a test failure is not counted in this metric.'
     instrument: counter

model/container/metrics.yaml

@@ -3,6 +3,9 @@ groups:
   - id: metric.container.uptime
     type: metric
     metric_name: container.uptime
+    annotations:
+      code_generation:
+        metric_value_type: double
     stability: development
     brief: "The time the container has been running"
     note: |
@@ -14,6 +17,9 @@ groups:
   - id: metric.container.cpu.time
     type: metric
     metric_name: container.cpu.time
+    annotations:
+      code_generation:
+        metric_value_type: double
     stability: development
     brief: "Total CPU time consumed"
     note: >
@@ -30,6 +36,9 @@ groups:
   - id: metric.container.cpu.usage
     type: metric
     metric_name: container.cpu.usage
+    annotations:
+      code_generation:
+        metric_value_type: double
     stability: development
     brief: "Container's CPU usage, measured in cpus. Range from 0 to the number of allocatable CPUs"
     note: >
@@ -47,6 +56,9 @@ groups:
   - id: metric.container.memory.usage
     type: metric
     metric_name: container.memory.usage
+    annotations:
+      code_generation:
+        metric_value_type: int
     stability: development
     brief: "Memory usage of the container."
     note: >
@@ -58,6 +70,9 @@ groups:
   - id: metric.container.disk.io
     type: metric
     metric_name: container.disk.io
+    annotations:
+      code_generation:
+        metric_value_type: int
     stability: development
     brief: "Disk bytes for the container."
     note: >
@@ -73,6 +88,9 @@ groups:
   - id: metric.container.network.io
     type: metric
     metric_name: container.network.io
+    annotations:
+      code_generation:
+        metric_value_type: int
     stability: development
     brief: "Network bytes for the container."
     note: >

model/cpu/deprecated.yaml

@@ -2,6 +2,9 @@ groups:
   - id: metric.cpu.time
     type: metric
     metric_name: cpu.time
+    annotations:
+      code_generation:
+        metric_value_type: double
     brief: "Deprecated. Use `system.cpu.time` instead."
     deprecated:
       reason: renamed
@@ -17,6 +20,9 @@ groups:
   - id: metric.cpu.utilization
     type: metric
     metric_name: cpu.utilization
+    annotations:
+      code_generation:
+        metric_value_type: double
     brief: "Deprecated. Use `system.cpu.utilization` instead."
     deprecated:
       reason: renamed
@@ -32,6 +38,9 @@ groups:
   - id: metric.cpu.frequency
     type: metric
     metric_name: cpu.frequency
+    annotations:
+      code_generation:
+        metric_value_type: int
     brief: "Deprecated. Use `system.cpu.frequency` instead."
     deprecated:
       reason: renamed

model/cpython/metrics.yaml

@@ -2,6 +2,9 @@ groups:
   - id: metric.cpython.gc.collections
     type: metric
     metric_name: cpython.gc.collections
+    annotations:
+      code_generation:
+        metric_value_type: int
     brief: "The number of times a generation was collected since interpreter start."
     note: >
       This metric reports data from [`gc.stats()`](https://docs.python.org/3/library/gc.html#gc.get_stats).
@@ -15,6 +18,9 @@ groups:
   - id: metric.cpython.gc.collected_objects
     type: metric
     metric_name: cpython.gc.collected_objects
+    annotations:
+      code_generation:
+        metric_value_type: int
     brief: "The total number of objects collected inside a generation since interpreter start."
     note: >
       This metric reports data from [`gc.stats()`](https://docs.python.org/3/library/gc.html#gc.get_stats).
@@ -28,6 +34,9 @@ groups:
   - id: metric.cpython.gc.uncollectable_objects
     type: metric
     metric_name: cpython.gc.uncollectable_objects
+    annotations:
+      code_generation:
+        metric_value_type: int
     brief: "The total number of objects which were found to be uncollectable inside a generation since interpreter start."
     note: >
       This metric reports data from [`gc.stats()`](https://docs.python.org/3/library/gc.html#gc.get_stats).

model/database/deprecated/metrics-deprecated.yaml

@@ -2,6 +2,9 @@ groups:
   - id: metric.db.client.connections.usage
     type: metric
     metric_name: db.client.connections.usage
+    annotations:
+      code_generation:
+        metric_value_type: int
     stability: development
     deprecated:
       reason: renamed
@@ -18,6 +21,9 @@ groups:
   - id: metric.db.client.connections.idle.max
     type: metric
     metric_name: db.client.connections.idle.max
+    annotations:
+      code_generation:
+        metric_value_type: int
     stability: development
     deprecated:
       reason: renamed
@@ -32,6 +38,9 @@ groups:
   - id: metric.db.client.connections.idle.min
     type: metric
     metric_name: db.client.connections.idle.min
+    annotations:
+      code_generation:
+        metric_value_type: int
     stability: development
     deprecated:
       reason: renamed
@@ -46,6 +55,9 @@ groups:
   - id: metric.db.client.connections.max
     type: metric
     metric_name: db.client.connections.max
+    annotations:
+      code_generation:
+        metric_value_type: int
     stability: development
     deprecated:
       reason: renamed
@@ -60,6 +72,9 @@ groups:
   - id: metric.db.client.connections.pending_requests
     type: metric
     metric_name: db.client.connections.pending_requests
+    annotations:
+      code_generation:
+        metric_value_type: int
     stability: development
     deprecated:
       reason: renamed
@@ -74,6 +89,9 @@ groups:
   - id: metric.db.client.connections.timeouts
     type: metric
     metric_name: db.client.connections.timeouts
+    annotations:
+      code_generation:
+        metric_value_type: int
     stability: development
     deprecated:
       reason: renamed
@@ -88,6 +106,9 @@ groups:
   - id: metric.db.client.connections.create_time
     type: metric
     metric_name: db.client.connections.create_time
+    annotations:
+      code_generation:
+        metric_value_type: double
     stability: development
     deprecated:
       reason: uncategorized
@@ -102,6 +123,9 @@ groups:
   - id: metric.db.client.connections.wait_time
     type: metric
     metric_name: db.client.connections.wait_time
+    annotations:
+      code_generation:
+        metric_value_type: double
     stability: development
     deprecated:
       reason: uncategorized
@@ -116,6 +140,9 @@ groups:
   - id: metric.db.client.connections.use_time
     type: metric
     metric_name: db.client.connections.use_time
+    annotations:
+      code_generation:
+        metric_value_type: double
     stability: development
     deprecated:
       reason: uncategorized
@@ -130,6 +157,9 @@ groups:
   - id: metric.db.client.cosmosdb.operation.request_charge
     type: metric
     metric_name: db.client.cosmosdb.operation.request_charge
+    annotations:
+      code_generation:
+        metric_value_type: double
     brief: "Deprecated, use `azure.cosmosdb.client.operation.request_charge` instead."
     deprecated:
       reason: renamed
@@ -165,6 +195,9 @@ groups:
   - id: metric.db.client.cosmosdb.active_instance.count
     type: metric
     metric_name: db.client.cosmosdb.active_instance.count
+    annotations:
+      code_generation:
+        metric_value_type: int
     brief: "Deprecated, use `azure.cosmosdb.client.active_instance.count` instead."
     deprecated:
       reason: renamed