Skip to content

Commit 73a29a4

Browse files
committed
PR feedback
1 parent 10fec8d commit 73a29a4

File tree

2 files changed

+24
-24
lines changed

2 files changed

+24
-24
lines changed

docs/dotnet/dotnet-aspnetcore-metrics.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -319,9 +319,9 @@ Meter name: `Microsoft.AspNetCore.RateLimiting`; Added in: ASP.NET Core 8.0
319319

320320
All memory pool metrics are reported by the `Microsoft.AspNetCore.MemoryPool` meter.
321321

322-
### Metric: `aspnetcore.memory_pool.current_memory`
322+
### Metric: `aspnetcore.memory_pool.pooled`
323323

324-
<!-- semconv metric.aspnetcore.memory_pool.current_memory -->
324+
<!-- semconv metric.aspnetcore.memory_pool.pooled -->
325325
<!-- NOTE: THIS TEXT IS AUTOGENERATED. DO NOT EDIT BY HAND. -->
326326
<!-- see templates/registry/markdown/snippet.md.j2 -->
327327
<!-- prettier-ignore-start -->
@@ -330,7 +330,7 @@ All memory pool metrics are reported by the `Microsoft.AspNetCore.MemoryPool` me
330330

331331
| Name | Instrument Type | Unit (UCUM) | Description | Stability | Entity Associations |
332332
| -------- | --------------- | ----------- | -------------- | --------- | ------ |
333-
| `aspnetcore.memory_pool.current_memory` | UpDownCounter | `By` | Number of bytes that are currently pooled by the pool. [1] | ![Development](https://img.shields.io/badge/-development-blue) | |
333+
| `aspnetcore.memory_pool.pooled` | UpDownCounter | `By` | Number of bytes currently pooled and available for reuse. [1] | ![Development](https://img.shields.io/badge/-development-blue) | |
334334

335335
**[1]:** Meter name: `Microsoft.AspNetCore.MemoryPool`; Added in: ASP.NET Core 10.0
336336

@@ -345,9 +345,9 @@ All memory pool metrics are reported by the `Microsoft.AspNetCore.MemoryPool` me
345345
<!-- END AUTOGENERATED TEXT -->
346346
<!-- endsemconv -->
347347

348-
### Metric: `aspnetcore.memory_pool.evicted_memory`
348+
### Metric: `aspnetcore.memory_pool.evicted`
349349

350-
<!-- semconv metric.aspnetcore.memory_pool.evicted_memory -->
350+
<!-- semconv metric.aspnetcore.memory_pool.evicted -->
351351
<!-- NOTE: THIS TEXT IS AUTOGENERATED. DO NOT EDIT BY HAND. -->
352352
<!-- see templates/registry/markdown/snippet.md.j2 -->
353353
<!-- prettier-ignore-start -->
@@ -356,7 +356,7 @@ All memory pool metrics are reported by the `Microsoft.AspNetCore.MemoryPool` me
356356

357357
| Name | Instrument Type | Unit (UCUM) | Description | Stability | Entity Associations |
358358
| -------- | --------------- | ----------- | -------------- | --------- | ------ |
359-
| `aspnetcore.memory_pool.evicted_memory` | Counter | `By` | Total number of bytes that have been evicted. [1] | ![Development](https://img.shields.io/badge/-development-blue) | |
359+
| `aspnetcore.memory_pool.evicted` | Counter | `By` | Total number of bytes evicted from the memory pool. Eviction occurs when idle pooled memory is reclaimed. [1] | ![Development](https://img.shields.io/badge/-development-blue) | |
360360

361361
**[1]:** Meter name: `Microsoft.AspNetCore.MemoryPool`; Added in: ASP.NET Core 10.0
362362

@@ -371,9 +371,9 @@ All memory pool metrics are reported by the `Microsoft.AspNetCore.MemoryPool` me
371371
<!-- END AUTOGENERATED TEXT -->
372372
<!-- endsemconv -->
373373

374-
### Metric: `aspnetcore.memory_pool.total_allocated`
374+
### Metric: `aspnetcore.memory_pool.allocated`
375375

376-
<!-- semconv metric.aspnetcore.memory_pool.total_allocated -->
376+
<!-- semconv metric.aspnetcore.memory_pool.allocated -->
377377
<!-- NOTE: THIS TEXT IS AUTOGENERATED. DO NOT EDIT BY HAND. -->
378378
<!-- see templates/registry/markdown/snippet.md.j2 -->
379379
<!-- prettier-ignore-start -->
@@ -382,7 +382,7 @@ All memory pool metrics are reported by the `Microsoft.AspNetCore.MemoryPool` me
382382

383383
| Name | Instrument Type | Unit (UCUM) | Description | Stability | Entity Associations |
384384
| -------- | --------------- | ----------- | -------------- | --------- | ------ |
385-
| `aspnetcore.memory_pool.total_allocated` | Counter | `By` | Total number of allocations made by the pool. [1] | ![Development](https://img.shields.io/badge/-development-blue) | |
385+
| `aspnetcore.memory_pool.allocated` | Counter | `By` | Total number of bytes allocated by the memory pool. Allocation occurs when a memory rental request exceeds the available pooled memory. [1] | ![Development](https://img.shields.io/badge/-development-blue) | |
386386

387387
**[1]:** Meter name: `Microsoft.AspNetCore.MemoryPool`; Added in: ASP.NET Core 10.0
388388

@@ -397,9 +397,9 @@ All memory pool metrics are reported by the `Microsoft.AspNetCore.MemoryPool` me
397397
<!-- END AUTOGENERATED TEXT -->
398398
<!-- endsemconv -->
399399

400-
### Metric: `aspnetcore.memory_pool.total_rented`
400+
### Metric: `aspnetcore.memory_pool.rented`
401401

402-
<!-- semconv metric.aspnetcore.memory_pool.total_rented -->
402+
<!-- semconv metric.aspnetcore.memory_pool.rented -->
403403
<!-- NOTE: THIS TEXT IS AUTOGENERATED. DO NOT EDIT BY HAND. -->
404404
<!-- see templates/registry/markdown/snippet.md.j2 -->
405405
<!-- prettier-ignore-start -->
@@ -408,7 +408,7 @@ All memory pool metrics are reported by the `Microsoft.AspNetCore.MemoryPool` me
408408

409409
| Name | Instrument Type | Unit (UCUM) | Description | Stability | Entity Associations |
410410
| -------- | --------------- | ----------- | -------------- | --------- | ------ |
411-
| `aspnetcore.memory_pool.total_rented` | Counter | `By` | Total number of rented bytes from the pool. [1] | ![Development](https://img.shields.io/badge/-development-blue) | |
411+
| `aspnetcore.memory_pool.rented` | Counter | `By` | Total number of bytes rented from the memory pool. [1] | ![Development](https://img.shields.io/badge/-development-blue) | |
412412

413413
**[1]:** Meter name: `Microsoft.AspNetCore.MemoryPool`; Added in: ASP.NET Core 10.0
414414

model/aspnetcore/metrics.yaml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -144,56 +144,56 @@ groups:
144144
requirement_level: required
145145

146146
# memory_pool
147-
- id: metric.aspnetcore.memory_pool.current_memory
147+
- id: metric.aspnetcore.memory_pool.pooled
148148
type: metric
149-
metric_name: aspnetcore.memory_pool.current_memory
149+
metric_name: aspnetcore.memory_pool.pooled
150150
annotations:
151151
code_generation:
152152
metric_value_type: int
153153
stability: development
154-
brief: Number of bytes that are currently pooled by the pool.
154+
brief: Number of bytes currently pooled and available for reuse.
155155
instrument: updowncounter
156156
unit: "By"
157157
note: |
158158
Meter name: `Microsoft.AspNetCore.MemoryPool`; Added in: ASP.NET Core 10.0
159159
extends: aspnetcore.common.memory_pool.metrics.attributes
160160

161-
- id: metric.aspnetcore.memory_pool.total_allocated
161+
- id: metric.aspnetcore.memory_pool.allocated
162162
type: metric
163-
metric_name: aspnetcore.memory_pool.total_allocated
163+
metric_name: aspnetcore.memory_pool.allocated
164164
annotations:
165165
code_generation:
166166
metric_value_type: int
167167
stability: development
168-
brief: Total number of allocations made by the pool.
168+
brief: Total number of bytes allocated by the memory pool. Allocation occurs when a memory rental request exceeds the available pooled memory.
169169
instrument: counter
170170
unit: "By"
171171
note: |
172172
Meter name: `Microsoft.AspNetCore.MemoryPool`; Added in: ASP.NET Core 10.0
173173
extends: aspnetcore.common.memory_pool.metrics.attributes
174174

175-
- id: metric.aspnetcore.memory_pool.evicted_memory
175+
- id: metric.aspnetcore.memory_pool.evicted
176176
type: metric
177-
metric_name: aspnetcore.memory_pool.evicted_memory
177+
metric_name: aspnetcore.memory_pool.evicted
178178
annotations:
179179
code_generation:
180180
metric_value_type: int
181181
stability: development
182-
brief: Total number of bytes that have been evicted.
182+
brief: Total number of bytes evicted from the memory pool. Eviction occurs when idle pooled memory is reclaimed.
183183
instrument: counter
184184
unit: "By"
185185
note: |
186186
Meter name: `Microsoft.AspNetCore.MemoryPool`; Added in: ASP.NET Core 10.0
187187
extends: aspnetcore.common.memory_pool.metrics.attributes
188188

189-
- id: metric.aspnetcore.memory_pool.total_rented
189+
- id: metric.aspnetcore.memory_pool.rented
190190
type: metric
191-
metric_name: aspnetcore.memory_pool.total_rented
191+
metric_name: aspnetcore.memory_pool.rented
192192
annotations:
193193
code_generation:
194194
metric_value_type: int
195195
stability: development
196-
brief: Total number of rented bytes from the pool.
196+
brief: Total number of bytes rented from the memory pool.
197197
instrument: counter
198198
unit: "By"
199199
note: |

0 commit comments

Comments
 (0)