Skip to content

Commit 830fd78

Browse files
committed
PSI stall time unit changed to seconds
1 parent 860573e commit 830fd78

File tree

2 files changed

+15
-13
lines changed

2 files changed

+15
-13
lines changed

docs/system/system-metrics.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1335,11 +1335,9 @@ over the specified time window.
13351335
PSI is available on Linux systems with kernel 4.20 or later and requires CONFIG_PSI=y.
13361336
CPU "full" stall is reported as zero at the system level for backward compatibility (available since 5.13).
13371337

1338-
The ratios are tracked over 10-second, 60-second,
1339-
and 300-second windows.
1338+
The ratios are tracked over 10-second, 60-second and 300-second windows.
13401339

1341-
See [Linux kernel PSI documentation](https://docs.kernel.org/accounting/psi.html) and
1342-
[/proc/pressure/*](https://man7.org/linux/man-pages/man5/proc.5.html) files.
1340+
See [Linux kernel PSI documentation](https://docs.kernel.org/accounting/psi.html)
13431341

13441342
**Attributes:**
13451343

@@ -1394,9 +1392,9 @@ This metric is [recommended][MetricRecommended].
13941392

13951393
| Name | Instrument Type | Unit (UCUM) | Description | Stability | Entity Associations |
13961394
| -------- | --------------- | ----------- | -------------- | --------- | ------ |
1397-
| `system.linux.psi.total_time` | Counter | `us` | Linux Pressure Stall Information (PSI) total cumulative stall time. [1] | ![Development](https://img.shields.io/badge/-development-blue) | [`host`](/docs/registry/entities/host.md#host) |
1395+
| `system.linux.psi.total_time` | Counter | `s` | Linux Pressure Stall Information (PSI) total cumulative stall time. [1] | ![Development](https://img.shields.io/badge/-development-blue) | [`host`](/docs/registry/entities/host.md#host) |
13981396

1399-
**[1]:** This metric tracks the total absolute stall time in microseconds since system boot.
1397+
**[1]:** This metric tracks the total absolute stall time since system boot.
14001398
Unlike the percentage-based `system.linux.psi.pressure` metric, this allows detection
14011399
of latency spikes that wouldn't necessarily make a noticeable impact on time averages.
14021400
It also enables calculating average trends over custom time frames.
@@ -1406,6 +1404,9 @@ CPU "full" stall is reported as zero at the system level for backward compatibil
14061404

14071405
This is a monotonically increasing counter that resets on system reboot.
14081406

1407+
Linux exposes this metric in microseconds. Following OpenTelemetry guidelines for measuring durations,
1408+
this metric uses seconds.
1409+
14091410
See [Linux kernel PSI documentation](https://docs.kernel.org/accounting/psi.html)
14101411

14111412
**Attributes:**

model/system/metrics.yaml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -581,11 +581,9 @@ groups:
581581
PSI is available on Linux systems with kernel 4.20 or later and requires CONFIG_PSI=y.
582582
CPU "full" stall is reported as zero at the system level for backward compatibility (available since 5.13).
583583
584-
The ratios are tracked over 10-second, 60-second,
585-
and 300-second windows.
584+
The ratios are tracked over 10-second, 60-second and 300-second windows.
586585
587-
See [Linux kernel PSI documentation](https://docs.kernel.org/accounting/psi.html) and
588-
[/proc/pressure/*](https://man7.org/linux/man-pages/man5/proc.5.html) files.
586+
See [Linux kernel PSI documentation](https://docs.kernel.org/accounting/psi.html)
589587
instrument: gauge
590588
unit: "1"
591589
attributes:
@@ -603,11 +601,11 @@ groups:
603601
metric_name: system.linux.psi.total_time
604602
annotations:
605603
code_generation:
606-
metric_value_type: int
604+
metric_value_type: double
607605
stability: development
608606
brief: "Linux Pressure Stall Information (PSI) total cumulative stall time."
609607
note: |
610-
This metric tracks the total absolute stall time in microseconds since system boot.
608+
This metric tracks the total absolute stall time since system boot.
611609
Unlike the percentage-based `system.linux.psi.pressure` metric, this allows detection
612610
of latency spikes that wouldn't necessarily make a noticeable impact on time averages.
613611
It also enables calculating average trends over custom time frames.
@@ -617,9 +615,12 @@ groups:
617615
618616
This is a monotonically increasing counter that resets on system reboot.
619617
618+
Linux exposes this metric in microseconds. Following OpenTelemetry guidelines for measuring durations,
619+
this metric uses seconds.
620+
620621
See [Linux kernel PSI documentation](https://docs.kernel.org/accounting/psi.html)
621622
instrument: counter
622-
unit: "us"
623+
unit: "s"
623624
attributes:
624625
- ref: system.psi.resource
625626
requirement_level: required

0 commit comments

Comments
 (0)