Skip to content

Commit c1c2afa

Browse files
authored
nfs/metrics.yaml: nfs.server.net.count: add missing network.transport attribute (#2858)
1 parent 44b54f3 commit c1c2afa

File tree

3 files changed

+46
-0
lines changed

3 files changed

+46
-0
lines changed
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# Use this changelog template to create an entry for release notes.
2+
#
3+
# If your change doesn't affect end users you should instead start
4+
# your pull request title with [chore] or use the "Skip Changelog" label.
5+
6+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
7+
change_type: bug_fix
8+
9+
# The name of the area of concern in the attributes-registry, (e.g. http, cloud, db)
10+
component: nfs
11+
12+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
13+
note: "nfs/metrics.yaml: nfs.server.net.count: add missing network.transport attribute. Implementation not merged, so not a breaking change."
14+
15+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
16+
# The values here must be integers.
17+
issues: [39978]
18+
19+
# (Optional) One or more lines of additional information to render under the primary note.
20+
# These lines will be padded with 2 spaces and then inserted directly into the document.
21+
# Use pipe (|) for multiline entries.
22+
subtext:

docs/nfs/nfs-metrics.md

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -337,6 +337,28 @@ This metric is [recommended][MetricRecommended].
337337

338338
**[1]:** Linux: this metric is taken from the Linux kernel's svc_stat.nettcpcnt and svc_stat.netudpcnt
339339

340+
| Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability |
341+
|---|---|---|---|---|---|
342+
| [`network.transport`](/docs/registry/attributes/network.md) | string | [OSI transport layer](https://wikipedia.org/wiki/Transport_layer) or [inter-process communication method](https://wikipedia.org/wiki/Inter-process_communication). [1] | `tcp`; `udp` | `Recommended` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
343+
344+
**[1] `network.transport`:** The value SHOULD be normalized to lowercase.
345+
346+
Consider always setting the transport when setting a port number, since
347+
a port number is ambiguous without knowing the transport. For example
348+
different processes could be listening on TCP port 12345 and UDP port 12345.
349+
350+
---
351+
352+
`network.transport` has the following list of well-known values. If one of them applies, then the respective value MUST be used; otherwise, a custom value MAY be used.
353+
354+
| Value | Description | Stability |
355+
|---|---|---|
356+
| `pipe` | Named or anonymous pipe. | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
357+
| `quic` | QUIC | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
358+
| `tcp` | TCP | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
359+
| `udp` | UDP | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
360+
| `unix` | Unix domain socket | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
361+
340362
<!-- markdownlint-restore -->
341363
<!-- prettier-ignore-end -->
342364
<!-- END AUTOGENERATED TEXT -->

model/nfs/metrics.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,8 @@ groups:
147147
note: |
148148
Linux: this metric is taken from the Linux kernel's svc_stat.nettcpcnt and svc_stat.netudpcnt
149149
instrument: counter
150+
attributes:
151+
- ref: network.transport
150152
unit: "{record}"
151153
entity_associations:
152154
- host

0 commit comments

Comments
 (0)