Skip to content

Commit d2ed009

Browse files
committed
Add note for performance implications
1 parent 3c7d992 commit d2ed009

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

docs/database/database-spans.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -502,6 +502,8 @@ If the propagator does not provide any value, the instrumentation SHOULD NOT inj
502502
SELECT * FROM songs /*traceparent='00-4bf92f3577b34da6a3ce929d0e0e4736-00f067aa0ba902b7-01',tracestate='congo%3Dt61rcWkgMzE%2Crojo%3D00f067aa0ba902b7'*/
503503
```
504504

505+
Note that adding high cardinality comments, like `traceparent` and `tracestate`, to queries can impact the performance for some database systems, like MySQL. See [this related issue](https://github.com/google/sqlcommenter/issues/284) for more details.
506+
505507
- For a query `SELECT * FROM songs` with a custom propagator that injects `service.name` into carrier where `service.name` is `shoppingcart`:
506508

507509
```sql

0 commit comments

Comments
 (0)