Skip to content

Commit d35c749

Browse files
committed
Remove service propagator from the definition of sql commenter
1 parent ff2afa9 commit d35c749

File tree

1 file changed

+1
-13
lines changed

1 file changed

+1
-13
lines changed

docs/database/database-spans.md

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -503,19 +503,7 @@ If the propagator does not provide any value, the instrumentation SHOULD NOT inj
503503
SELECT * FROM songs /*traceparent='00-4bf92f3577b34da6a3ce929d0e0e4736-00f067aa0ba902b7-01',tracestate='congo%3Dt61rcWkgMzE%2Crojo%3D00f067aa0ba902b7'*/
504504
```
505505

506-
### `service-name` propagator
507-
508-
The `service-name` propagator is a propagator that can inject the `service.name` resource attribute into carrier.
509-
510-
SDK contrib MAY provide this propagator for databases context propagation.
511-
512-
The `service-name` propagator need to be manually configured by the user to know the `service.name` value if OpenTelemetry does not have a way to automatically fetch the `service.name` value.
513-
514-
Note that the performance of certain database systems may be impacted by high cardinality values in comments. The `service-name` propagator is useful for these databases with minimal performance impact while providing useful context.
515-
516-
**Examples with `service-name` propagator:**
517-
518-
- For a query `SELECT * FROM songs` where `service.name` is `shoppingcart`:
506+
- For a query `SELECT * FROM songs` with a custom propagator that injects `service.name` into carrier where `service.name` is `shoppingcart`:
519507

520508
```sql
521509
SELECT * FROM songs /*service.name='shoppingcart'*/

0 commit comments

Comments
 (0)